Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Metadata extraction for BKA (National Acedemy of Science Belarus) #38

Merged
merged 4 commits into from
Nov 5, 2023

Conversation

floeschau
Copy link
Collaborator

With this change, a new metadata extractor for BKA data and related unit tests are added.

@codecov-commenter
Copy link

Codecov Report

Merging #38 (1632287) into develop (77e7637) will decrease coverage by 41.98%.
The diff coverage is 10.31%.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##           develop      #38       +/-   ##
============================================
- Coverage    56.37%   14.39%   -41.98%     
============================================
  Files          237      239        +2     
  Lines        34375    34724      +349     
  Branches      2905     2948       +43     
============================================
- Hits         19378     4999    -14379     
- Misses       14997    29725    +14728     
Flag Coverage Δ
unittests 14.39% <10.31%> (-41.98%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
src/Stars.Data/Model/Metadata/Bka/Schema.cs 0.00% <0.00%> (ø)
...rs.Data/Model/Metadata/Bka/BkaMetadataExtractor.cs 14.40% <14.40%> (ø)

... and 106 files with indirect coverage changes

@emmanuelmathot emmanuelmathot merged commit ee2896c into develop Nov 5, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants