Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for cloud coverage filter on Copernicus Data Space OData #39

Merged
merged 1 commit into from
Nov 5, 2023

Conversation

floeschau
Copy link
Collaborator

@floeschau floeschau commented Nov 3, 2023

With this change, filtering by cloud coverage for Sentinel-2 data works with Copernicus Data Space OData API.
The change is in the dependency Terradue.OpenSearch.SciHub, which was updated.

Cloud coverage filter values can be in different forms:

  • simple number (assumed to be the maximum desired value)
  • interval syntax (e.g. [10, 10], [10,20[, [10,20), [10,20], with these types of parenthesis to designate open or closed intervals: []()

@codecov-commenter
Copy link

Codecov Report

Merging #39 (dd0c498) into develop (77e7637) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           develop      #39   +/-   ##
========================================
  Coverage    56.37%   56.37%           
========================================
  Files          237      237           
  Lines        34375    34375           
  Branches      2905     2916   +11     
========================================
  Hits         19378    19378           
  Misses       14997    14997           
Flag Coverage Δ
unittests 56.37% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@emmanuelmathot emmanuelmathot merged commit 6ba3b1f into develop Nov 5, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants