Update to dateformat 5.0.3 #7317
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Version 4 contains significant performance improvements, and version 5 changes the import format, but reduces the bundle size, so update to that verison. This upgrade uncovered some type errors in DiffTool.tsx, so I converted the JulianDates to JavaScript Dates when they are known to be defined values.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
Version 4 contains significant
performance improvements, and version
5 changes the import format, but
reduces the bundle size, so update
to that verison.
This upgrade uncovered some type errors
in DiffTool.tsx, so I converted the
JulianDates to JavaScript Dates when
they are known to be defined values.
Test me
I believe this is tested by CI?
Checklist
doc/.