Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix lint #7321

Merged
merged 2 commits into from
Nov 21, 2024
Merged

Fix lint #7321

merged 2 commits into from
Nov 21, 2024

Conversation

na9da
Copy link
Collaborator

@na9da na9da commented Nov 21, 2024

What this PR does

Fixes lint errors, and an incorrect import from terriajs-cesium.

Test me

Specs should catch any errors.

Checklist

  • There are unit tests to verify my changes are correct or unit tests aren't applicable (if so, write quick reason why unit tests don't exist)
  • I've updated relevant documentation in doc/.
  • I've updated CHANGES.md with what I changed.
  • I've provided instructions in the PR description on how to test this PR.

@na9da na9da merged commit cf60c17 into main Nov 21, 2024
9 checks passed
@na9da na9da deleted the fix-lint branch November 21, 2024 05:44
@pjonsson
Copy link
Contributor

@na9da @ljowen I'm not sure how those errors flew past the CI for #7287, thanks for fixing it and sorry for the breakage.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ljowen ljowen ljowen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@na9da @pjonsson @ljowen