Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the proper name for UTF-8 in documentation #1014

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ilmari
Copy link
Contributor

@ilmari ilmari commented Nov 20, 2024

utf8 is the internal name for Perl's extended, lax UTF-8-like encoding, while UTF-8 is the stricter standard form

`utf8` is the internal name for Perl's extended, lax UTF-8-like
encoding, while `UTF-8` is the stricter standard form
@exodist
Copy link
Member

exodist commented Nov 20, 2024

The less strict form was used because many versions of perl (generally older ones) have a segv when using this stricter version:

Perl/perl5#7533

See note in https://github.com/Test-More/test-more/blob/master/lib/Test2/Formatter/TAP.pm#L73

If we change this in the file you modified we probably want to change it all over the Test-Simple dist, including where this note is. But that said I suspect making this change will break Test-Simple on a lot of older perls. Is that breakage worth the benefit?

Maybe we make it conditional, it uses the stricter one on perls without the segv, but uses the one that does not explode when necessary?

@exodist
Copy link
Member

exodist commented Nov 20, 2024

oof, I just noticed that this is a doc only change. So it can probably be merged as is.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants