Merge pull request #242 from ThatConference/ical/chore/node-20

ical-generator: chore: configure and test for node 20
ThatConference · Dec 1, 2023 · 9a03ae8 · 9a03ae8
2 parents c839577 + eaa9ab6
commit 9a03ae8
Show file tree

Hide file tree

Showing 6 changed files with 2,590 additions and 3,020 deletions.
diff --git a/.github/workflows/that-api-ical-generator_PullRequest.yml b/.github/workflows/that-api-ical-generator_PullRequest.yml
@@ -8,17 +8,17 @@ on:
 jobs:
   build:
     name: Build that-api-ical-generator
-    runs-on: ubuntu-latest
+    runs-on: ubuntu-22.04
 
     steps:
       - name: Checkout PR
         uses: actions/checkout@v3
         with:
           fetch-depth: 0
-      - name: Use Node.js 18
+      - name: Use Node.js 20
         uses: actions/setup-node@v3
         with:
-          node-version: 18
+          node-version: 20
       - name: npm ci, run validate
         run: |
           cd functions/that-api-ical-generator

diff --git a/.github/workflows/that-api-ical-generator_PushMaster.yml b/.github/workflows/that-api-ical-generator_PushMaster.yml
@@ -10,17 +10,17 @@ on:
 jobs:
   build:
     name: Build that-api-ical-generator
-    runs-on: ubuntu-latest
+    runs-on: ubuntu-22.04
 
     steps:
       - name: Checkout master
         uses: actions/checkout@v3
         with:
           fetch-depth: 0
-      - name: Use Node.js 18
+      - name: Use Node.js 20
         uses: actions/setup-node@v3
         with:
-          node-version: 18
+          node-version: 20
       - name: npm ci, run validate
         run: |
           cd functions/that-api-ical-generator
@@ -59,7 +59,7 @@ jobs:
   deploy-image:
     name: Deploy that-api-ical-generator
     needs: build
-    runs-on: ubuntu-latest
+    runs-on: ubuntu-22.04
     env:
       apiName: ical-generator
     steps:
@@ -71,7 +71,7 @@ jobs:
       - name: Setup gcloud Actions
         uses: google-github-actions/setup-gcloud@v0
         with:
-          version: '397.0.0'
+          version: "437.0.1"
           service_account_key: ${{ secrets.GCLOUD_AUTH }}
           project_id: ${{ secrets.GCP_PROJECT_ID }}
       - name: gcloud docker cred helper

diff --git a/functions/that-api-ical-generator/.node-version b/functions/that-api-ical-generator/.node-version
@@ -1 +1 @@
-18.16.0
+20.10.0
diff --git a/functions/that-api-ical-generator/Dockerfile b/functions/that-api-ical-generator/Dockerfile
@@ -1,6 +1,6 @@
 # THAT Dockerfile
 
-FROM node:18-alpine
+FROM node:20-alpine
 
 # Create and change to app directory
 WORKDIR /usr/src/that