Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle odd cases where schema is inaccurate #24

Merged
merged 2 commits into from
Feb 26, 2024
Merged

Conversation

marv7000
Copy link
Collaborator

What does this PR change?

Some OpenAPI schemas might be inaccurate and provide null values where they're not allowed. This PR takes a precaution by wrapping these fields in Option.

Tick the applicable box:

  • Add new feature
  • Security changes
  • Tests
  • Documentation changed

  • General Maintenance

@github-actions github-actions bot added the rust label Feb 26, 2024
Copy link
Member

@ByteOtter ByteOtter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ByteOtter ByteOtter merged commit 67c66f9 into main Feb 26, 2024
4 checks passed
@ByteOtter ByteOtter deleted the fix-struct-types branch February 26, 2024 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants