drt: nodes structure refactoring and elimination of getFlatIdx #5903
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: bernardo <[email protected]>
Signed-off-by: bernardo <[email protected]>
Signed-off-by: bernardo <[email protected]>
Signed-off-by: bernardo <[email protected]>
Signed-off-by: bernardo <[email protected]>
Signed-off-by: bernardo <[email protected]>
Signed-off-by: bernardo <[email protected]>
…nction Signed-off-by: bernardo <[email protected]>
Signed-off-by: bernardo <[email protected]>
Signed-off-by: bernardo <[email protected]>
Signed-off-by: bernardo <[email protected]>
Signed-off-by: bernardo <[email protected]>
Signed-off-by: bernardo <[email protected]>
|
clang-tidy review says "All clean, LGTM! 👍" |
Signed-off-by: bernardo <[email protected]>
|
clang-tidy review says "All clean, LGTM! 👍" |
bnmfw
changed the title
osamahammad21
requested changes
Oct 15, 2024
Comment on lines
+526
to
+527
| int getEdgeCost(FlexDPNode* prev_node_idx, | ||
| FlexDPNode* curr_node_idx, |
There was a problem hiding this comment.
Not idx anymore. Also why not send the object by reference?
Comment on lines
+595
to
+596
| int getEdgeCost(FlexDPNode* prev_node_idx, | ||
| FlexDPNode* curr_node_idx, |
| /*either {pin_idx, acc_point_idx} or {inst_idx, acc_pattern_idx} depending on | ||
| * context*/ | ||
| std::pair<int, int> idx_ = {-1, -1}; | ||
| FlexDPNode* prev_node_ = nullptr; |
There was a problem hiding this comment.
store prev_node_idx_ instead of pointer to FlexDPNode. safer to avoid memory reallocation causing dangling pointers. (or use vector<vector<unique_ptr>>)
| nodes[end_node_Idx].setNodeCost(0); | ||
| const int source_node_idx = insts.size() + 1; | ||
| nodes[source_node_idx] = std::vector<FlexDPNode>(1); | ||
| auto source_node = &(nodes[source_node_idx][0]); |
There was a problem hiding this comment.
auto& source_node = nodes[source_node_idx][0]
use the object reference instead of pointer
| for (int prev_acc_pattern_idx = 0; | ||
| prev_acc_pattern_idx < nodes[prev_inst_idx].size(); | ||
| prev_acc_pattern_idx++) { | ||
| auto prev_node = &(nodes[prev_inst_idx][prev_acc_pattern_idx]); |
There was a problem hiding this comment.
actually const ref since prev_node is not being edited here.
| for (int curr_acc_pattern_idx = 0; | ||
| curr_acc_pattern_idx < nodes[curr_inst_idx].size(); | ||
| curr_acc_pattern_idx++) { | ||
| auto curr_node = &(nodes[curr_inst_idx][curr_acc_pattern_idx]); |
Comment on lines
+1926
to
+1927
| auto drain_node = &(nodes[insts.size()][0]); | ||
| auto curr_node = drain_node; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR has a secure CI associated with it, is branched from #5901 and is waiting for it to merge.
Nodes structure change
The
nodesvector has been refactored to be a vector of vectors index by the old "nested id". This allowed for the elimination of thegetFlatIdx()function, as now the indexing for nodes is always done through both idx.This change impacts various parts of the code as the structure is present in most of the functions that work with Access Patterns.
getEdgeCost refactoring
This PR also contains some minor refactoring on getEdgeCost (both implementations).
The refactoring that does not have to do with the nodes restructuring are:
Do not try to look at changes, it currently has 4 PRs worth of contents, I just want to make it to organize myself and see the public CI.