Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

grt: check if edges are initialized before get congestion data #6199

Merged

Conversation

eder-matheus
Copy link
Collaborator

Fix Coverage pipeline issue.

Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

Copy link
Member

@maliberty maliberty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When does it happen that these are not initialized when calling saveCongestion?

@eder-matheus eder-matheus merged commit 02efda5 into The-OpenROAD-Project:master Nov 19, 2024
11 checks passed
@eder-matheus eder-matheus deleted the grt_fix_crash branch November 19, 2024 17:41
@eder-matheus
Copy link
Collaborator Author

When does it happen that these are not initialized when calling saveCongestion?

It happens when we initialize the nets. This process happens before initializing the edges of FastRouteCore.

@maliberty
Copy link
Member

Why do we call saveCongestion that early?

@eder-matheus
Copy link
Collaborator Author

Why do we call saveCongestion that early?

If I understand correctly, the code is catching the error and try to save the congestion here:
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants