Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add Depth first search #2815

Open
wants to merge 10 commits into
base: master
Choose a base branch
from
Open

feat: add Depth first search #2815

wants to merge 10 commits into from

Conversation

adi776borate
Copy link

Description of Change

  • Added a new function to count the number of paths in a graph.
  • Implemented a test case to validate the functionality of the new function.
  • Improved documentation for better understanding of the algorithm.

Checklist

  • Added description of change
  • Added file name matches File name guidelines
  • Added tests and example, test must pass
  • Added documentation so that the program is self-explanatory and educational - Doxygen guidelines
  • Relevant documentation/comments is changed or added
  • PR title follows semantic commit guidelines
  • Search previous suggestions before making a new one, as yours may be a duplicate.
  • I acknowledge that all my contributions will be made under the project's license.

Notes: The new function counts the number of unique paths between two nodes in a graph. It can be particularly useful in graph-related problems where pathfinding is necessary.

@realstealthninja realstealthninja changed the title feat: add count_paths algorithm with a test case feat: add Depth first search Oct 12, 2024
@adi776borate
Copy link
Author

I've updated the algorithm and added more test cases as per the feedback received. Please review the latest changes. Thank you!

realstealthninja
realstealthninja requested changes Oct 19, 2024
View reviewed changes
graph/number_of_paths.cpp Outdated Show resolved Hide resolved
graph/number_of_paths.cpp Outdated Show resolved Hide resolved
graph/number_of_paths.cpp Outdated Show resolved Hide resolved
realstealthninja
realstealthninja previously approved these changes Oct 31, 2024
View reviewed changes
Copy link
Collaborator

@realstealthninja realstealthninja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@realstealthninja realstealthninja added approved Approved; waiting for merge hacktoberfest-accepted Accepted to be counted towards Hacktoberfest labels Oct 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@realstealthninja realstealthninja realstealthninja left review comments

@Panquesito7 Panquesito7 Awaiting requested review from Panquesito7 Panquesito7 is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
approved Approved; waiting for merge hacktoberfest-accepted Accepted to be counted towards Hacktoberfest
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@adi776borate @realstealthninja