Add borrowed_reborrowable lint
#164
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BD103
added
A-Linter
BD103
reviewed
Nov 2, 2024
Sure thing! I'll change the name to |
MrGVSV
force-pushed
the
mrgvsv/borrow_of_reborrowable
branch
from
428c708
to
cc9c4a9
Compare
MrGVSV
force-pushed
the
mrgvsv/borrow_of_reborrowable
branch
2 times, most recently
from
28f8071
to
0161b02
Compare
BD103
reviewed
Nov 6, 2024
BD103
approved these changes
Nov 6, 2024
BD103
requested changes
Nov 6, 2024
There was a problem hiding this comment.
I just ran this over the Bevy engine source code and found this error:
warning: parameter takes `&mut ResMut` instead of a re-borrowed `ResMut`
--> crates/bevy_ecs/src/change_detection.rs:327:28
|
327 | fn set_changed(&mut self) {
| ^^^^^^^^^ help: use `ResMut` instead: `mut self: change_detection::ResMut<'w, T>`
...
661 | change_detection_mut_impl!(ResMut<'w, T>, T, Resource);
| ------------------------------------------------------ in this macro invocation
|
= note: `#[warn(bevy::borrowed_resource)]` on by defaultCould you add a special case that skips self parameters?
MrGVSV
force-pushed
the
mrgvsv/borrow_of_reborrowable
branch
from
74b57fe
to
b86e281
Compare
Co-authored-by: BD103 <[email protected]>
Co-authored-by: BD103 <[email protected]>
MrGVSV
force-pushed
the
mrgvsv/borrow_of_reborrowable
branch
from
b86e281
to
fb41fe4
Compare
Merged
BD103
added a commit
that referenced
this pull request
Nov 17, 2024
This, following the [release checklist](https://github.com/TheBevyFlock/bevy_cli/blob/663298e1e24a6422abd001b6142dc53f371c3bcd/bevy_lint/docs/release.md), updates `bevy_lint` to v0.2.0-dev. I also added some missing information to the release checklist, based off of my experience releasing v0.1.0. Once this is merged, the feature freeze will be lifted, letting #164 and #173 be merged.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #127
Adds the pedantic
borrowed_reborrowablelint to suggest that parameters using a mutable reference to a re-borrowable type instead switch to an owned instance of that type.See #127 for details.