Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide tool to run release workflow locally #49

Closed
benfrankel opened this issue Jul 7, 2024 · 8 comments · Fixed by #95
Closed

Provide tool to run release workflow locally #49

benfrankel opened this issue Jul 7, 2024 · 8 comments · Fixed by #95
Labels
enhancement New feature or request
Milestone

Comments

@benfrankel
Copy link
Collaborator

benfrankel commented Jul 7, 2024

This would allow users to test their changes e.g. on itch.io without having to go through the whole commit + trigger and wait for CD process, improving iteration times. This is especially useful if you only want to do the release for one particular platform, or if you pay for CD.

My repo has a bash script for this, which is better than nothing but not portable.

@benfrankel benfrankel added enhancement New feature or request good first issue Good for newcomers labels Jul 7, 2024
@benfrankel
Copy link
Collaborator Author

I've also had issues locally cross-compiling from Linux to Mac, so if we can resolve that as well as part of this issue that would be cool.

@MiniaczQ
Copy link
Collaborator

MiniaczQ commented Jul 7, 2024

I'm heavily against this, the compatibility with every user and maintenance aren't worth it.

@rparrett
Copy link
Contributor

rparrett commented Jul 7, 2024

There was a small amount of discussion in a similar (but not as ambitious) issue here: bevyengine/bevy_github_ci_template#8

@benfrankel benfrankel removed the good first issue Good for newcomers label Jul 7, 2024
@benfrankel
Copy link
Collaborator Author

benfrankel commented Jul 7, 2024

IMO this feature is important and in-scope (especially since we're considering bevy jam participants as potential users); but the approach to implementing it will be controversial.

@rparrett
Copy link
Contributor

rparrett commented Jul 7, 2024

Just to elaborate on my reasoning for writing that other issue the way I did:

IMO, doing cross-platform native builds easily is half the reason for having this CI setup in the first place, and I don't really want to have to write / test / maintain the code that does that.

But the most problematic / error-prone "cross-platform" situation is web (well, mobile too...), and being able to debug that without uploading to itch is pretty essential.

@benfrankel
Copy link
Collaborator Author

benfrankel commented Jul 7, 2024

I can see reducing the scope to just web, if only to get it in before Bevy Jam 5.

@janhohenheim
Copy link
Member

janhohenheim commented Jul 7, 2024

Very much agree with @rparrett and @MiniaczQ. We should have a way to easily run web builds locally, everything beyond that is out of scope for the moment.
I know many people use trunk for this, but I also know it has limitations in terms of what kind of build configuration it lets you pass along to cargo. Maybe they fixed that in the meantime, it's been a year or so since I looked into it.

@janhohenheim
Copy link
Member

janhohenheim commented Jul 9, 2024

Update: do not use trunk. See @rparrett's writeup here: bevy-cheatbook/bevy-cheatbook#253
Update after discussion: actually do use trunk

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants