Use trunk for local Wasm dev #95
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MiniaczQ
reviewed
Jul 9, 2024
Co-authored-by: MiniaczQ <[email protected]>
MiniaczQ
reviewed
Jul 9, 2024
MiniaczQ
reviewed
Jul 9, 2024
MiniaczQ
reviewed
Jul 9, 2024
MiniaczQ
approved these changes
Jul 9, 2024
Co-authored-by: Tau Gärtli <[email protected]>
benfrankel
reviewed
Jul 9, 2024
benfrankel
requested changes
Jul 9, 2024
benfrankel
approved these changes
Jul 9, 2024
NiklasEi
reviewed
Jul 9, 2024
There was a problem hiding this comment.
Not sure the no_spa option in Trunk.toml works. I served the template locally (looks nice btw!) and accessed localhost:8080/test and it still returned the index file...
One other weird thing I noticed: I can't navigate out of the game. If I click a bookmark while running the game it navigated back to the game.
|
@NiklasEi can confirm that the behavior is different when running |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #49
Resolves #25
Fixes Wasm builds on Windows in general due to bevyengine/bevy#14246
The readme is kinda trash because we are overhauling that anyways.