Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sa 3606 update commands json ci #527

Merged
merged 34 commits into from
Oct 11, 2023
Merged

Sa 3606 update commands json ci #527

merged 34 commits into from
Oct 11, 2023

Conversation

kmaranionjc
Copy link
Contributor

@kmaranionjc kmaranionjc commented Oct 10, 2023 •
edited by jira bot
Loading

Issues

  • SA-3606 - Commands Gallery CI Workflow

What does this solve?

Moving cicleci workflows and python scripts to GHActions. Added tests for functions and changes in commands gallery .json file

Is there anything particularly tricky?

How should this be tested?

  1. Create a test branch with this branch changes
  2. Edit one of the commands
  3. On your terminal go to /support/ .github/scripts
  4. Run: python3 build_commands_gallery.py
  5. Validated changes to commands_gallery.json
  6. Now go to: /support/ .github/scripts/tests and run pytest and an error like this should pop up:
    image
  7. Make changes to one of the python functions that will result to an error
  8. Rerun pytest again, validate that the error is caught.
  9. Create a PR to Master and label it Commands Gallery
  10. Validate in GHAction is running

Screenshots

@kmaranionjc kmaranionjc self-assigned this Oct 11, 2023
@kmaranionjc kmaranionjc requested a review from a team October 11, 2023 16:49
jworkmanjc
jworkmanjc requested changes Oct 11, 2023
View reviewed changes
Copy link
Contributor

@jworkmanjc jworkmanjc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm unsure all the packages in the requirements.txt are used. Can we confirm this before merging otherwise it looks good to me thank you for the work here.

.github/scripts/requirements.txt Show resolved Hide resolved
jworkmanjc
jworkmanjc approved these changes Oct 11, 2023
View reviewed changes
Copy link
Contributor

@jworkmanjc jworkmanjc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good thank you!

@gweinjc gweinjc self-requested a review October 11, 2023 20:29
@kmaranionjc kmaranionjc merged commit 535cf69 into master Oct 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gweinjc gweinjc gweinjc approved these changes

@jworkmanjc jworkmanjc jworkmanjc approved these changes

Assignees

@kmaranionjc kmaranionjc

Labels
Commands Gallery
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kmaranionjc @jworkmanjc @gweinjc