Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BAN-2126: Changes to Linux RAA install script #556

Merged
merged 5 commits into from
Jan 29, 2024
Merged

BAN-2126: Changes to Linux RAA install script #556

merged 5 commits into from
Jan 29, 2024

Conversation

asinghjc
Copy link
Contributor

@asinghjc asinghjc commented Jan 19, 2024

Issues

  • BAN-2126 - Changes to Linux RAA install script

What does this solve?

Is there anything particularly tricky?

How should this be tested?

Screenshots

@asinghjc asinghjc requested a review from a team as a code owner January 19, 2024 11:07
gweinjc
gweinjc previously approved these changes Jan 19, 2024
Copy link
Contributor

@gweinjc gweinjc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested good on my end

kmaranionjc
kmaranionjc previously approved these changes Jan 19, 2024
Copy link
Contributor

@jworkmanjc jworkmanjc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When running this command, I copy the entire script contents from the command body window. Paste into JumpCloud Command and execute the script on a device.

First time this is run I get an "exit 0" status and note that raa_version' need to be provided in the script (eg. v0.75.0) — which in my opinion is incorrect. It should be exit 1 if a customer sees this.

I'd imagine that customers have no clue what version they need to specify here. Is there a list of available somewhere that we can reference or can I just type v2.23.4 and hope for the best?

  • Script should throw exit 1 instead on line 22

Additionally after specifying the version suggested in the command the script returns an exit code: 1 noting:

x86_64 
bash: line 37: raa_directory: unbound variable
  • Unsure how to address this error

PowerShell/JumpCloud Commands Gallery/commands.json Outdated Show resolved Hide resolved
@jworkmanjc jworkmanjc dismissed stale reviews from kmaranionjc and gweinjc via c6f376a January 19, 2024 20:42
@asinghjc asinghjc requested a review from jworkmanjc January 25, 2024 14:04
Copy link
Contributor

@jworkmanjc jworkmanjc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay tested again! Now it's working I wish there was a way to always pull in the latest version of the APP instead of having the customer write to line 29 but I do see that the script is installing the RAA app now. Approved

Copy link
Contributor

@kmaranionjc kmaranionjc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Installed worked good on my end. Only is is the RAA version as per my comment.

@@ -25,15 +25,17 @@ fi
set -u

# set the RAA version string in the below variable before running the script.
# the example format of version: v0.75.0
# the example format of version: v0.172.0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This would be nice automated. I can see customers being confused on what the current version is.

@asinghjc asinghjc merged commit 458dff8 into master Jan 29, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

4 participants