Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cut 4324 policy group template #621

Merged
merged 33 commits into from
Nov 19, 2024
Merged

Cut 4324 policy group template #621

merged 33 commits into from
Nov 19, 2024

Conversation

jworkmanjc
Copy link
Contributor

@jworkmanjc jworkmanjc commented Nov 13, 2024 •
edited
Loading

Issues

  • CUT-4324 - Policy Group and Policy Group Template Functions

What does this solve?

  • Policy Group Functions added to the PowerShell Module
  • Policy Group Template Functions added to the PowerShell Module
  • Import/Update-JCUserFromCSV can now import/update users with "recoveryEmails"

Is there anything particularly tricky?

How should this be tested?

Screenshots

@jworkmanjc jworkmanjc added minor minor version release PowerShell Module Release for JumpCloud PowerShell Module labels Nov 13, 2024
@jworkmanjc jworkmanjc requested a review from a team as a code owner November 13, 2024 23:28
@kmaranionjc kmaranionjc self-requested a review November 19, 2024 18:04
kmaranionjc
kmaranionjc approved these changes Nov 19, 2024
View reviewed changes
Copy link
Contributor

@kmaranionjc kmaranionjc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work here. Thanks for including the JCAPIKEY validation work. Looks good on my end.

@gweinjc gweinjc self-requested a review November 19, 2024 20:01
gweinjc
gweinjc approved these changes Nov 19, 2024
View reviewed changes
Copy link
Contributor

@gweinjc gweinjc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good to me. Nice!

@jworkmanjc jworkmanjc merged commit 048483c into master Nov 19, 2024
10 checks passed
@jworkmanjc jworkmanjc temporarily deployed to PublishToPSGallery November 19, 2024 22:03 — with GitHub Actions Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kmaranionjc kmaranionjc kmaranionjc approved these changes

@gweinjc gweinjc gweinjc approved these changes

Assignees
No one assigned
Labels
minor minor version release PowerShell Module Release for JumpCloud PowerShell Module
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jworkmanjc @gweinjc @kmaranionjc