Changed coveralls workflow to run Python 3.5/3.6 on ubuntu-20.04 #375
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andy-maier
force-pushed
the
andy/fix-ubuntu-py35+36
branch
from
86ee57b
to
13c498b
Compare
andy-maier
changed the title
|
could 3.5/3.6 dropped from supported? |
Not as far as our projects are concerned, because we still need to support Python 3.5 and 3.6, and we urgently need a solution for #252 and it would be great if we could get that solution also for Python 3.5 and 3.6. Note that I think I found a fix for #252 with PR #385. |
Details: * Github Actions change ubuntu-latest recently to now be Ubuntu 22.04, and Python 3.5 and 3.6 are no longer provided by GitHub Actions on that Ubuntu version. This change fixes that by using ubuntu-20.04 for those Python versions. Signed-off-by: Andreas Maier <[email protected]>
andy-maier
force-pushed
the
andy/fix-ubuntu-py35+36
branch
from
13c498b
to
5ace857
Compare
|
Thanks for the contribution! However, Python 3.5 and 3.6 have been dropped as they are now end-of-life'd. Please see #393 (comment) for more context. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue #374 .
For details, see the commit message.