Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

html_css: move accessibility lessons into accessibility folder #23620

Closed
wants to merge 2 commits into from
Closed

html_css: move accessibility lessons into accessibility folder #23620

wants to merge 2 commits into from

Conversation

01zulfi
Copy link
Member

@01zulfi 01zulfi commented Feb 17, 2022 •
edited
Loading

  • I have thoroughly read and understand The Odin Project Contributing Guide
  • The title of this PR follows the where the change occurs: brief description of change format, e.g. Intro to HTML and CSS lesson: Fix link text
  • I have previewed all lesson file(s) included in this PR with the Markdown preview tool to ensure the Markdown content is formatted correctly.
  • If one exists, I have linked a related open issue to this PR in Step 2 below
  • If changes were requested, I have made them and re-requested a review from the maintainer (top of the right sidebar)

1. Description of the Changes

Reason:

This commit will move the wrong file into the accessibility folder. In this moving, it will apply changes from this pull request to add KCs to the new file. Hopefully, now these changes will propagate to the website.

2. Related Issue

Closes #XXXXX

@01zulfi 01zulfi added Status: Needs Review Type: Bug Involves something that isn't working as intended and removed Status: Needs Review labels Feb 17, 2022
@01zulfi
move all accessibility lessons into accessibility folder
8d88b80 
- this will delete the duplicate file
- this will apply any new changes that were made in the wrong files
- i made sure this didn't override any new changes that were made in the correct files before this moving
@01zulfi 01zulfi changed the title html_css: move accessiblity_auditing.md to accessiblity folder html_css: move accessibility lessons into accessibility folder Feb 17, 2022
@dm-murphy dm-murphy added Status: Do Not Merge This PR should not be merged until further notice and removed Status: In Progress labels Feb 17, 2022
@dm-murphy dm-murphy self-requested a review February 17, 2022 18:00
@01zulfi
Copy link
Member Author

01zulfi commented Mar 3, 2022

This PR is invalid now that the old lessons have been moved to archive in #23692. Closing it now.

@01zulfi 01zulfi closed this Mar 3, 2022
@01zulfi 01zulfi deleted the duplicate-accessibility-auditing-file branch March 3, 2022 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dm-murphy dm-murphy Awaiting requested review from dm-murphy

Assignees
No one assigned
Labels
Status: Do Not Merge This PR should not be merged until further notice Type: Bug Involves something that isn't working as intended
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@01zulfi @dm-murphy