Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rails_programming: rename files & folders and move webpacker.md to archive #23760

Merged
merged 10 commits into from
Mar 22, 2022

Conversation

01zulfi
Copy link
Member

@01zulfi 01zulfi commented Mar 11, 2022

Complete the following REQUIRED checkboxes:

  • I have thoroughly read and understand The Odin Project Contributing Guide
  • The title of this PR follows the location of change: brief description of change format, e.g. Intro to HTML and CSS lesson: Fix link text

Complete the following checkboxes ONLY IF they are applicable to your PR. You can complete them later if they are not currently applicable:

  • I have previewed all lesson files included in this PR with the Markdown preview tool to ensure the Markdown content is formatted correctly
  • I have ensured all lesson files included in this PR follow the Layout Style Guide

1. Because:

Related to:

  1. Cleaning up folder/file structure in the curriculum repository top-meta#109

2. This PR:

  1. Moves webpacker.md to archive.
  2. Renames files and folders to match course structure on the website.

3. Additional Information:

n/a

01zulfi added 6 commits March 11, 2022 14:59
* introduction/introduction.md -> introduction/how_this_course_will_work.md
* introduction/installing_rails.md -> introduction/project_installing_rails.md
* move webpacker.md to archive
* rename rails_basics/controller_basics.md -> rails_basics/controllers.md
* rename project_ar_basics.md to project_micro_reddit.md
in advanced_forms_and_activerecord and forms_and_authentication
* apis/api_basics.md -> apis/apis_and_building_your_own.md
* apis/project_using_an_api.md -> apis/project_flickr_api.md
* apis/api_interfacing.md -> apis/working_with_external_apis.md
to project_sending_confirmation_emails.md
@01zulfi 01zulfi added Status: Do Not Review This issue/PR should not be reviewed until further notice Type: Epic This issue is a larger, unnamed project with several moving parts labels Mar 11, 2022
@01zulfi 01zulfi added Status: Needs Review and removed Status: Do Not Review This issue/PR should not be reviewed until further notice labels Mar 11, 2022
Copy link
Member

@KevinMulhern KevinMulhern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we put the webpacker lesson within a rails folder in the archive please @01zulfi? just so it will be easier to find when theres a lot of lessons in the archive.

Everything else looks great 👍

@01zulfi 01zulfi requested a review from KevinMulhern March 13, 2022 13:24
@KevinMulhern
Copy link
Member

Nice work, thanks @01zulfi 🚀

@01zulfi
Copy link
Member Author

01zulfi commented Mar 14, 2022

Renamed rails_programming to ruby_on_rails, @KevinMulhern

@KevinMulhern
Copy link
Member

Looks good to me @01zulfi 👍

@01zulfi
Copy link
Member Author

01zulfi commented Mar 15, 2022

Holding to merge until #23797 is merged.

@01zulfi 01zulfi added Status: Do Not Merge This PR should not be merged until further notice and removed Status: Awaiting Changes labels Mar 15, 2022
@KevinMulhern
Copy link
Member

Hey @01zulfi, I think we should merge this as soon as we can since we don't have an eta on the turbo forms PR and this PR changes more files, increasing the likely hood of conflicts.

@01zulfi 01zulfi removed the Status: Do Not Merge This PR should not be merged until further notice label Mar 22, 2022
@01zulfi 01zulfi merged commit 01ce39b into TheOdinProject:main Mar 22, 2022
@01zulfi 01zulfi deleted the rails-cleanup branch March 27, 2022 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Epic This issue is a larger, unnamed project with several moving parts
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants