Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ruby folder: update README.md #24055

Merged
merged 2 commits into from
Apr 21, 2022
Merged

Conversation

kzhang01
Copy link
Contributor

Complete the following REQUIRED checkboxes:

  • I have thoroughly read and understand The Odin Project Contributing Guide
  • The title of this PR follows the location of change: brief description of change format, e.g. Intro to HTML and CSS lesson: Fix link text

Complete the following checkboxes ONLY IF they are applicable to your PR. You can complete them later if they are not currently applicable:

  • I have previewed all lesson files included in this PR with the Markdown preview tool to ensure the Markdown content is formatted correctly
  • I have ensured all lesson files included in this PR follow the Layout Style Guide

1. Because:

Closes #24033

2. This PR:

  • changed layout to reflect example in issue description
  • updated broken links
  • ensured lesson order matches website
  • made projects bold

3. Additional Information:

ruby/README.md Outdated
Comment on lines 52 to 54
### Intermediate Git
1. [A Deeper Look at Git](../git/intermediate_git/a_deeper_look_at_git.md)
2. [Using Git in the Real World](../git/intermediate_git/using_git_in_the_real_world.md)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I should've mentioned this in the issue. We don't need to include the links for the Intermediate Git section here. It's already covered in the git's folder README.

Can you please remove this section from here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done! I removed it in my most recent commit

@01zulfi 01zulfi added Status: Awaiting Changes Type: Documentation Involves an update to the documentation labels Apr 21, 2022
Copy link
Member

@01zulfi 01zulfi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this 🔥

@01zulfi 01zulfi merged commit 5558537 into TheOdinProject:main Apr 21, 2022
@kzhang01 kzhang01 deleted the ruby-folder-readme branch April 23, 2022 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Documentation Involves an update to the documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ruby folder: update README.md
2 participants