Skip to content

Commit

Permalink
Enhancement: Center course titles in course listing (#4165)
Browse files Browse the repository at this point in the history
<!-- Thank you for taking the time to contribute to The Odin Project. In
order to get this pull request (PR) merged in a reasonable amount of
time, you must complete this entire template. -->

## Because
<!-- Summarize the purpose or reasons for this PR, e.g. what problem it
solves or what benefit it provides. -->
Aligning course titles in the course listing cards. 

## This PR
<!-- A bullet point list of one or more items describing the specific
changes. -->

- added tailwind class 'rounded-lg' to link
- added `flex grow items-center` to the headings

## Issue
<!--
If this PR closes an open issue in this repo, replace the XXXXX below
with the issue number, e.g. Closes #2013.

If this PR closes an open issue in another TOP repo, replace the #XXXXX
with the URL of the issue, e.g. Closes
https://github.com/TheOdinProject/curriculum/issues/XXXXX

If this PR does not close, but is related to another issue or PR, you
can link it as above without the 'Closes' keyword, e.g. 'Related to
#2013'.
-->
Related to #4153 

## Additional Information
<!-- Any other information about this PR, such as a link to a Discord
discussion. -->


## Pull Request Requirements
<!-- Replace the whitespace between the square brackets with an 'x',
e.g. [x]. After you create the PR, they will become checkboxes that you
can click on. -->
- [ X] I have thoroughly read and understand [The Odin Project
Contributing
Guide](https://github.com/TheOdinProject/theodinproject/blob/main/CONTRIBUTING.md)
- [X ] The title of this PR follows the `keyword: brief description of
change` format, using one of the following keywords:
    - `Feature` - adds new or amends existing user-facing behavior
- `Chore` - changes that have no user-facing value, refactors,
dependency bumps, etc
    - `Fix` - bug fixes
-   [ X] The `Because` section summarizes the reason for this PR
- [ X] The `This PR` section has a bullet point list describing the
changes in this PR
- [X ] I have verified all tests and linters pass after making these
changes.
- [ ] If this PR addresses an open issue, it is linked in the `Issue`
section
-   [ ] If applicable, this PR includes new or updated automated tests
  • Loading branch information
VenkaSri authored Sep 22, 2023
1 parent 48e3b26 commit 51b7b88
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions app/views/static_pages/home/_curriculum.html.erb
Original file line number Diff line number Diff line change
Expand Up @@ -7,9 +7,9 @@
<div class="flex flex-row flex-wrap justify-center mb-4">
<% courses.each do |course| %>
<%= link_to path_course_path(course.path, course),
class: 'w-60 sm:w-56 bg-white dark:bg-gray-800 dark:border dark:border-gray-700 py-6 px-10 flex flex-col items-center text-center hover:shadow-lg m-4' do %>
class: 'rounded-lg w-60 sm:w-56 bg-white dark:bg-gray-800 dark:border dark:border-gray-700 py-6 px-10 flex flex-col items-center text-center hover:shadow-lg m-4' do %>
<%= image_tag course.badge_uri, alt: '', class: 'h-20 w-20 sm:h-40 sm:w-40' %>
<h3 class="font-semibold text-xl mt-4">
<h3 class="font-semibold text-xl mt-4 flex grow items-center">
<%= course.title %>
</h3>
<% end %>
Expand Down

0 comments on commit 51b7b88

Please sign in to comment.