Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chore: update JavaScript lesson URLs and rename 'ES?' lesson to 'What is ES6?' #2844

Merged
merged 2 commits into from
Apr 21, 2022
Merged

Chore: update JavaScript lesson URLs and rename 'ES?' lesson to 'What is ES6?' #2844

merged 2 commits into from
Apr 21, 2022

Conversation

01zulfi
Copy link
Member

@01zulfi 01zulfi commented Apr 14, 2022

Complete the following REQUIRED checkboxes:

  • I have thoroughly read and understand The Odin Project Contributing Guide
  • The title of this PR follows the keyword: brief description of change format, using one of the following keywords:
  • Feature - adds new or amends existing user-facing behaviour
  • Chore - changes that have no user-facing value, refactors, dependency bumps, etc
  • Fix - bug fixes

Complete the following checkbox ONLY IF it is applicable to your PR. You can complete it later if it is not currently applicable:

  • I have verified all tests and linters pass against my changes, and/or I have included automated tests where applicable

1. Because:

Related to:

2. This PR:

  1. Update lesson URLs based on JavaScript folder: rename few folders/files for consistency curriculum#24023
  2. Rename 'ES?' lesson to 'What is ES6?' because the current lesson title is too vague and doesn't convey what the lesson content would cover

3. Additional Information:

n/a

01zulfi added 2 commits April 14, 2022 14:46
@01zulfi
update urls in javascript_lessons.rb
32533bb 
reason: due to changes in the curriculum repository
@01zulfi
rename 'ES?' lesson to 'What is ES6?'
73082fc 
reason: current lesson title is too vague
@01zulfi 01zulfi added Status: Needs Review This issue/PR needs an initial or additional review Type: Chore Involves changes with no user-facing value, to the build process/internal tooling, refactors, etc. Type: Epic This issue is a larger, unnamed project with several moving parts labels Apr 14, 2022
@01zulfi 01zulfi added Status: Do Not Merge This PR should not be merged until further notice and removed Status: Needs Review This issue/PR needs an initial or additional review Status: Do Not Merge This PR should not be merged until further notice labels Apr 18, 2022
@01zulfi 01zulfi merged commit f4703d1 into TheOdinProject:main Apr 21, 2022
@01zulfi 01zulfi deleted the update-js-seeds branch April 22, 2022 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KevinMulhern KevinMulhern KevinMulhern approved these changes

Assignees
No one assigned
Labels
Type: Chore Involves changes with no user-facing value, to the build process/internal tooling, refactors, etc. Type: Epic This issue is a larger, unnamed project with several moving parts
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@01zulfi @KevinMulhern