Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Add Community Onboarding Steps #3056

Closed
wants to merge 2 commits into from

Conversation

rlmoser99
Copy link
Member

Complete the following REQUIRED checkboxes:

  • I have thoroughly read and understand The Odin Project Contributing Guide
  • The title of this PR follows the keyword: brief description of change format, using one of the following keywords:
  • Feature - adds new or amends existing user-facing behaviour
  • Chore - changes that have no user-facing value, refactors, dependency bumps, etc
  • Fix - bug fixes

Complete the following checkbox ONLY IF it is applicable to your PR. You can complete it later if it is not currently applicable:

  • I have verified all tests and linters pass against my changes, and/or I have included automated tests where applicable

1. Because:

  • The current community information is buried in Foundations
  • These lesson is long and needs to be split into smaller articles
  • Every Discord community member needs to be aware of the rules
  • Every Discord community member needs to know how to ask a question

Related to TheOdinProject/top-meta#66

2. This PR:

  • Adds CommunityOnboardingComponent and test
  • Adds community controller and route
  • Adds community_onboarded and community_onboarding_steps to user model
  • Adds update_onboarding_steps to user's controller & route
  • Adds tests for user_spec and community#show
  • Update user's ability to update onboarding steps
  • Translate dashboard_steps markdown to html
  • Adds partials for github_link and form for checkbox
  • Darkened background of app's checkbox
  • Replace ODIN_CHAT_URL with community_path
  • Update welcome email templates
  • Removes 2 lessons: Asking For Help & Join the Odin Community

3. Additional Information:
When this PR is ready to merge (or right after), we will need to make an announcement in Discord because the behavior of the "Community" link is changing drastically.

In addition, after it is merged we will need to change links throughout the curriculum and in Discord's rule channel because this PR changes the id's to more readable format.

Because:
* The current community information is buried in Foundations
* These lesson is long and needs to be split into smaller articles
* Every Discord community member needs to be aware of the rules
* Every Discord community member needs to know how to ask a question

This Commit:
* Adds CommunityOnboardingComponent and test
* Adds community controller and route
* Adds community_onboarded and community_onboarding_steps to user model
* Adds update_onboarding_steps to user's controller & route
* Adds tests for user_spec and community#show
* Update user's ability to update onboarding steps
* Translate dashboard_steps markdown to html
* Adds partials for github_link and form for checkbox
* Darkened background of app's checkbox
* Replace ODIN_CHAT_URL with community_path
* Update welcome email templates
* Removes 2 lessons: Asking For Help & Join the Odin Community
@KevinMulhern KevinMulhern temporarily deployed to theodinproject-pr-3056 July 2, 2022 22:26 Inactive
@KevinMulhern KevinMulhern temporarily deployed to theodinproject-pr-3056 July 2, 2022 22:27 Inactive
@CouchofTomato
Copy link
Member

This has probably been discussed but with this change the intention is only those registered for a TOP account will now have access to the discord?

@rlmoser99
Copy link
Member Author

@CouchofTomato Good question! Yes, it has been discussed at team meetings and also in this thread with an earlier version of screenshots.
https://discord.com/channels/505093832157691914/945856689360486400/945871399799623691

@rlmoser99
Copy link
Member Author

Change Requested: Create a new discord invite link, so that moving forward we can track what invite links people are using.

@KevinMulhern KevinMulhern temporarily deployed to theodinproject-pr-3056 July 10, 2022 01:03 Inactive
@ChargrilledChook ChargrilledChook added the Type: Enhancement Involves a new feature or enhancement request label Jul 10, 2022
@KevinMulhern KevinMulhern requested review from I3uckwheat and removed request for I3uckwheat July 10, 2022 13:51
@rlmoser99
Copy link
Member Author

Closing due to the team deciding to not implement this feature. Instead we will be making a community page feature.
TheOdinProject/top-meta#204

@rlmoser99 rlmoser99 closed this Sep 11, 2022
@rlmoser99 rlmoser99 deleted the feature/community-steps branch September 11, 2022 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Enhancement Involves a new feature or enhancement request
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants