Chore: Convert community article markdown to html #3284
Conversation
There was a problem hiding this comment.
Nice work @rlmoser99 💪
I have a few suggestions based on what we've been doing with TW. But overall, this looks great.
| @@ -1,11 +1,87 @@ | |||
| <%= title('Community Expectations') %> | |||
| <% filename = 'app/views/static_pages/dashboard_steps/community_expectations.md' %> | |||
| <div class="gradient py-8"> | |||
There was a problem hiding this comment.
We have a page-container that be used here. It will give us consistent spacing between navbar/footer and content for all pages.
| <div class="gradient py-8"> | |
| <div class="page-container"> |
| @@ -1,11 +1,87 @@ | |||
| <%= title('Community Expectations') %> | |||
| <% filename = 'app/views/static_pages/dashboard_steps/community_expectations.md' %> | |||
| <div class="gradient py-8"> | |||
| <div class="col-xl-8 offset-xl-2 text-gray-500"> | |||
There was a problem hiding this comment.
To keep the same content styling throughout the site, we can add these classes to this container div:
| <div class="col-xl-8 offset-xl-2 text-gray-500"> | |
| <div class="lesson-content prose prose-lg prose-gold max-w-prose mx-auto"> |
After-which, We can remove all the individual classes on headings, paragraphs and lists within the container.
| We encourage questions, so do not worry about asking a “stupid question”. However, it is important that you know <a href="/before_asking" class="text-gold-600 underline decoration-solid" target="_blank">How to Help Yourself Before Asking Others</a> and follow our tips on <a href="/how_to_ask" class="text-gold-600 underline decoration-solid" target="_blank">How to Ask a Technical Question</a>. In addition, to ensure that everyone has the same expectations, below are some specific guidelines on asking questions: | ||
| </p> | ||
|
|
||
| <div class="card-main"> |
There was a problem hiding this comment.
With the prose classes applied, I think this looks and flows better without card styling
Same for the other lists that are using card-main below.
|
Thanks for the suggestions @KevinMulhern, as I wasn't entirely sure how to implement the tailwind updates. Do you have a preference if I should break up the really long lines for each paragraph? It makes it hard to view the files on github, but can use word wrap when using a code editor. |
|
No strong preferences @rlmoser99, I like to be more relaxed with line lengths in views. I suppose we could break up some of the longer lines at natural breakpoints in the content. But totally up to you, it's by no means a blocker from me. |
There was a problem hiding this comment.
Nice work @rlmoser99, looks great 🏆
Before merging can we squash the commits into one please?
KevinMulhern
added
the
Type: Enhancement
Because - Using html we can apply unique styles to these pages This - Removes the community expectations markdown file - Converts it to html and applies some basic styling
rlmoser99
force-pushed
the
chore/update-community-expectations
branch
from
65c1827 to
e7497ad
Compare
Complete the following REQUIRED checkboxes:
keyword: brief description of changeformat, using one of the following keywords:Feature- adds new or amends existing user-facing behaviourChore- changes that have no user-facing value, refactors, dependency bumps, etcFix- bug fixesComplete the following checkbox ONLY IF it is applicable to your PR. You can complete it later if it is not currently applicable:
1. Because:
Using html we can apply unique styles to these community articles
Related to Community Landing Page feature
2. This PR:
3. Additional Information:
I wanted to start with converting one file, since they will share the majority of styling. Then I'll take any changes that we decide on and apply them to the other 3 community pages (that have already been converted).