Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature: adding working with remotes lesson #4202

Merged
merged 10 commits into from
Oct 1, 2023
Merged

Feature: adding working with remotes lesson #4202

merged 10 commits into from
Oct 1, 2023

Conversation

CBID2
Copy link
Contributor

@CBID2 CBID2 commented Sep 29, 2023 •
edited
Loading

Because

I'm adding a new lesson to the Intermediate Git section

This PR

  • I turned the working remotes section into its own lesson, so now this PR adds it to the Intermediate Git section.

Issue

Closes (TheOdinProject/curriculum#26118)

Additional Information

This pull request is a work in progress. I'm currently having syntax issues whenever I do the bin/rails db:seed command in my terminal. Suggestions to solve this problem would be greatly appreciated.

Pull Request Requirements

  • I have thoroughly read and understand The Odin Project Contributing Guide
  • The title of this PR follows the keyword: brief description of change format, using one of the following keywords:
    • Feature - adds new or amends existing user-facing behavior
    • Chore - changes that have no user-facing value, refactors, dependency bumps, etc
    • Fix - bug fixes
  • The Because section summarizes the reason for this PR
  • The This PR section has a bullet point list describing the changes in this PR
  • I have verified all tests and linters pass after making these changes.
  • If this PR addresses an open issue, it is linked in the Issue section
  • If applicable, this PR includes new or updated automated tests

@CBID2 CBID2 mentioned this pull request Sep 29, 2023
Merged
7 tasks
CBID2
CBID2 commented Sep 29, 2023
View reviewed changes
Copy link
Contributor Author

@CBID2 CBID2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @wise-king-sullyman. I posted a comment that needs your attention. Can you check it out when you're free?

KevinMulhern
KevinMulhern requested changes Sep 30, 2023
View reviewed changes
db/fixtures/lessons/git_lessons.rb Outdated Show resolved Hide resolved
db/fixtures/lessons/git_lessons.rb Outdated Show resolved Hide resolved
wise-king-sullyman
wise-king-sullyman requested changes Sep 30, 2023
View reviewed changes
Copy link
Member

@wise-king-sullyman wise-king-sullyman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You'll need to add the lesson to the intermediate Git lessons in the JS path as well

@CBID2
Copy link
Contributor Author

CBID2 commented Sep 30, 2023

You'll need to add the lesson to the intermediate Git lessons in the JS path as well

Ahh ok

@CBID2
Copy link
Contributor Author

CBID2 commented Sep 30, 2023 •
edited
Loading

Success has been made @wise-king-sullyman and @KevinMulhern! :)

@CBID2 CBID2 marked this pull request as ready for review September 30, 2023 19:45
@KevinMulhern KevinMulhern temporarily deployed to odin-review-app-pr-4202 October 1, 2023 09:35 Inactive
KevinMulhern
KevinMulhern approved these changes Oct 1, 2023
View reviewed changes
Copy link
Member

@KevinMulhern KevinMulhern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code changes look good to me, nice work @CBID2

We'll need the curriculum changes to be merged before we can give the final QA to test everything is hooked up correctly.

@CBID2
Copy link
Contributor Author

CBID2 commented Oct 1, 2023

Code changes look good to me, nice work @CBID2

We'll need the curriculum changes to be merged before we can give the final QA to test everything is hooked up correctly.
Ok @KevinMulhern. The new curriculum changes are in here

@wise-king-sullyman wise-king-sullyman added the create-review-app Create a Heroku review app for pull request label Oct 1, 2023
wise-king-sullyman
wise-king-sullyman approved these changes Oct 1, 2023
View reviewed changes
Copy link
Member

@wise-king-sullyman wise-king-sullyman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great 🚀 great work on this!

@wise-king-sullyman wise-king-sullyman merged commit d671390 into TheOdinProject:main Oct 1, 2023
1 of 2 checks passed
@CBID2 CBID2 deleted the adding-working-withremotes-lesson branch October 1, 2023 19:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KevinMulhern KevinMulhern KevinMulhern approved these changes

@wise-king-sullyman wise-king-sullyman wise-king-sullyman approved these changes

Assignees
No one assigned
Labels
create-review-app Create a Heroku review app for pull request
Projects
Main Site
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@CBID2 @wise-king-sullyman @KevinMulhern