Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: Switch from Eslint to Standard #4731

Merged
merged 1 commit into from
Aug 11, 2024
Merged

Conversation

KevinMulhern
Copy link
Member

Because:

  • We only need a light touch with linting in our Stimulus Controllers.
  • We never make use of how configurable eslint is.

This commit

  • Removes Eslint and its config file
  • Removes Babel and its config file
  • Adds Standard and fixes all the failing lint issues

@KevinMulhern KevinMulhern temporarily deployed to odin-review-app-pr-4731 August 9, 2024 11:56 Inactive
@KevinMulhern KevinMulhern force-pushed the chore/switch-to-standard-js branch from 2b258a4 to 07f2928 Compare August 10, 2024 07:17
@KevinMulhern KevinMulhern temporarily deployed to odin-review-app-pr-4731 August 10, 2024 07:18 Inactive
@KevinMulhern KevinMulhern force-pushed the chore/switch-to-standard-js branch from 07f2928 to 49ca6ee Compare August 10, 2024 11:23
@KevinMulhern KevinMulhern temporarily deployed to odin-review-app-pr-4731 August 10, 2024 11:24 Inactive
@KevinMulhern KevinMulhern force-pushed the chore/switch-to-standard-js branch from 49ca6ee to 1e2e924 Compare August 10, 2024 11:24
@KevinMulhern KevinMulhern temporarily deployed to odin-review-app-pr-4731 August 10, 2024 11:25 Inactive
@KevinMulhern KevinMulhern force-pushed the chore/switch-to-standard-js branch from 1e2e924 to 5772cd3 Compare August 10, 2024 11:28
@KevinMulhern KevinMulhern temporarily deployed to odin-review-app-pr-4731 August 10, 2024 11:28 Inactive
@KevinMulhern KevinMulhern force-pushed the chore/switch-to-standard-js branch from 5772cd3 to a6ba45c Compare August 10, 2024 11:50
@KevinMulhern KevinMulhern temporarily deployed to odin-review-app-pr-4731 August 10, 2024 11:50 Inactive
Because:
- We only need a light touch with linting in our Stimulus Controllers.
- We never make use of how configurable eslint is.

This commit
- Removes Eslint and its config file
- Removes Babel and its config file
- Adds Standard and fixes all the failing lint issues
@KevinMulhern KevinMulhern force-pushed the chore/switch-to-standard-js branch from a6ba45c to 8392d3a Compare August 11, 2024 07:52
@KevinMulhern KevinMulhern temporarily deployed to odin-review-app-pr-4731 August 11, 2024 07:52 Inactive
@KevinMulhern KevinMulhern merged commit c3c8712 into main Aug 11, 2024
2 checks passed
@KevinMulhern KevinMulhern deleted the chore/switch-to-standard-js branch August 11, 2024 07:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants