Chore: Use inline-svg helper with all applicable SVGs #4774
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because: - We had a few SVGs that were using plain SVG syntax in the views. This commit: - Renames ham-burger.svg to bars-3.svg to bring it inline with Heroicons naming - Removes the x.svg icon - its the exact same as the x-mark.svg icon - Replace open menu button SVGs with the inline_svg helper - Replace closer and dismiss button SVGs with the inline_svg helper
KevinMulhern
force-pushed
the
chore/move-svgs-into-icons-folder
branch
from
bc92e76 to
d0bdbe1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because:
This commit: