Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore - Updated twitter.svg #4871

Merged
merged 3 commits into from
Dec 8, 2024

Conversation

tanmayc43
Copy link
Contributor

@tanmayc43 tanmayc43 commented Dec 7, 2024

Updated the old Twitter bird logo to the new "X" logo.

Because

The old twitter bird logo has been long replaced by the new "X" logo and I have done the same on the website to keep it updated and improve the overall user experience.

This PR

-The old bird logo SVG file was replaced by the new "X" logo SVG file.
-The fill rules were modified accordingly.

Pull Request Requirements

  • I have thoroughly read and understand The Odin Project Contributing Guide
  • The title of this PR follows the keyword: brief description of change format, using one of the following keywords:
    • Feature - adds new or amends existing user-facing behavior
    • Chore - changes that have no user-facing value, refactors, dependency bumps, etc
    • Fix - bug fixes
  • The Because section summarizes the reason for this PR
  • The This PR section has a bullet point list describing the changes in this PR
  • I have verified all tests and linters pass after making these changes.
  • If this PR addresses an open issue, it is linked in the Issue section
  • If applicable, this PR includes new or updated automated tests

@tanmayc43 tanmayc43 marked this pull request as ready for review December 7, 2024 14:01
@KevinMulhern KevinMulhern temporarily deployed to odin-review-app-pr-4871 December 8, 2024 11:04 Inactive
Copy link
Member

@KevinMulhern KevinMulhern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for contributing @tanmayc43!

The new icon is bigger than our other social icons:

Screenshot 2024-12-08 at 11 09 28

We'll need this to look uniform before we can merge!

@KevinMulhern KevinMulhern temporarily deployed to odin-review-app-pr-4871 December 8, 2024 13:34 Inactive
@tanmayc43
Copy link
Contributor Author

Thank you for your response !

I have edited the .svg file accordingly and scaled down the logo for uniformity.

Screenshot 2024-12-08 191219

Copy link
Member

@KevinMulhern KevinMulhern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @tanmayc43, much appreciated!

@KevinMulhern KevinMulhern merged commit 8175df7 into TheOdinProject:main Dec 8, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants