Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Trapper Information gain as it "should be" #492

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Peybro
Copy link

@Peybro Peybro commented Feb 23, 2024

The way it is now:

The trapper gets his information about the players from the traps at the time the meeting starts (or when the chat is available).

The problem with this is that if a player in the trap gets a sidekick, the trapper will magically see the sidekick in the meeting and not the player's role when they were in the trap.

What the PR changes:

Since the trapper receives their information via the trap, they should not notice any subsequent changes. With the PR, the trapper receives the role information about the player at the time in the trap.

@Peybro Peybro changed the title Fix Trapper Info Fix Trapper Information gain as it "should be" Feb 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant