Fixes

TheRandomLabs · Mar 14, 2020 · 834423e · 834423e
1 parent b3ed981
commit 834423e
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 1 deletion.
diff --git a/src/main/java/com/therandomlabs/changeloggenerator/BasicChangelogGenerator.java b/src/main/java/com/therandomlabs/changeloggenerator/BasicChangelogGenerator.java
@@ -189,7 +189,7 @@ protected void appendChangelogEntries(
 				fileChanges,
 				fileChange -> Optional.ofNullable(fileChange.project()).
 						map(CurseProject::name).
-						orElse("Deleted project (" + fileChange.projectID() + ")"),
+						orElseGet(() -> "Deleted project (" + fileChange.projectID() + ")"),
 				this::getChangelogEntries
 		));
 

diff --git a/src/test/java/com/therandomlabs/changeloggenerator/ChangelogGeneratorTest.java b/src/test/java/com/therandomlabs/changeloggenerator/ChangelogGeneratorTest.java
@@ -32,7 +32,9 @@
 import com.therandomlabs.changeloggenerator.provider.CurseChangelogProvider;
 import com.therandomlabs.curseapi.CurseAPI;
 import com.therandomlabs.curseapi.CurseException;
+import com.therandomlabs.curseapi.file.BasicCurseFile;
 import com.therandomlabs.curseapi.file.CurseFile;
+import com.therandomlabs.curseapi.file.CurseFilesComparison;
 import com.therandomlabs.curseapi.minecraft.modpack.CurseModpack;
 import com.therandomlabs.utils.io.ZipFile;
 import org.junit.jupiter.api.Test;
@@ -76,6 +78,17 @@ public void atm4ChangelogIsValid(@TempDir Path tempDirectory) throws Exception {
 					BasicChangelogGenerator.instance.generate(oldModpack, newModpack);
 			assertThat(changelog).isNotEmpty();
 
+			final CurseFilesComparison<BasicCurseFile> comparison =
+					CurseFilesComparison.of(oldModpack.files(), newModpack.files());
+			final ChangelogEntries entries = BasicChangelogGenerator.instance.getChangelogEntries(
+					comparison.updated().iterator().next()
+			);
+
+			assertThat(entries).isNotNull();
+			assertThat(entries.toString()).isNotEmpty();
+			assertThat(entries.entries()).isNotEmpty();
+			assertThat(entries.entries().first().toString()).isNotEmpty();
+
 			LoggerFactory.getLogger(getClass()).info(changelog);
 		}
 	}