-
Notifications
You must be signed in to change notification settings - Fork 238
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
A Extension, Reservation Table, and Multi-threading Support #121
Draft
giancarlopernudisegura
wants to merge
93
commits into
TheThirdOne:master
Choose a base branch
from
giancarlopernudisegura:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
A Extension, Reservation Table, and Multi-threading Support #121
giancarlopernudisegura
wants to merge
93
commits into
TheThirdOne:master
from
giancarlopernudisegura:master
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…isegura/rars into ReservationTable
…isegura/rars into ReservationTable
still have to sync enable/disable status with main gui
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR seeks to solve #75. To implement the A extension and use it to its fullest extent, we also need to implement a reservation table tool and some multi-threading support. Since this is a lot of work and we're not even done, I'm creating this draft PR to keep track and get early feedback since we're not even done and the changes are already huge.
Our current progress
So far we've implemented:
lr.w
andlr.d
instructions) in order to simulate another hart writing to memory which will makesc.w
andsc.d
fail as otherwise, it would always succeed since there currently aren't any other harts.TODO
There are some edge cases when unreserving addresses in 64-bit mode that we're going to fix.We have to write unit tests for all the instructions that we're adding