Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiline comment support #203

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

sdasda7777
Copy link

Fixes #100. Implements support for multiline comments such as /* comment */.

The example file riscv1_min.asm (file extension changed to be allowed here) renders and compiles like this (the colour in editor being user selectable):
image
image
image

@sdasda7777
Copy link
Author

There was actually a bug with check for the terminating */, where it wouldn't be found by compiler nor highlighter if it was sooner than the third character on the given line. Following is a new example riscv1_min.asm as rendered and compiled by the current version:

image
image

@sdasda7777
Copy link
Author

I'll probably make a separate pull request later, but I also translated the build script to PowerShell for simple* building on Windows

$JAVA_SDK_DIRECTORY = "C:\Program Files\Java\jdk-17.0.1\bin"

if (git submodule status | findstr "\(") {
    # Create build folder
    New-Item -Force -ItemType "directory" build > $null
    # Compile src/*.java files
    &"$JAVA_SDK_DIRECTORY\javac.exe" -encoding UTF8 -d build @(
        Get-ChildItem -Recurse -Path src/ -Filter *.java | ForEach-Object {Resolve-Path $_.FullName -Relative})
    # Exit if compilation error happened
    if ( -Not $? ) {
        exit 1
    }
    # Copy src/*.java files to build/
    robocopy src/ build/ /S /XF *.jar /nfl /ndl /np /njh /njs
    robocopy ./ build/ README.md License.txt /nfl /ndl /np /njh /njs
    cd build
    # Create .jar file from build/
    &"$JAVA_SDK_DIRECTORY\jar.exe" cfm ../rars.jar ./META-INF/MANIFEST.MF *
    cd ..
} else {
    echo "It looks like JSoftFloat is not cloned. Consider running \"git submodule update --init\""
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Comment Multiple Lines
1 participant