Skip to content

Commit

Permalink
Cleanup in many places
Browse files Browse the repository at this point in the history
  • Loading branch information
ThexXTURBOXx committed Oct 28, 2023
1 parent 181a370 commit 72bf3ee
Show file tree
Hide file tree
Showing 29 changed files with 400 additions and 448 deletions.
50 changes: 39 additions & 11 deletions analysis_options.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -46,38 +46,40 @@ linter:
# `// ignore_for_file: name_of_lint` syntax on the line or in the file
# producing the lint.
rules:
# avoid_print: false # Uncomment to disable the `avoid_print` rule
# prefer_single_quotes: true # Uncomment to enable the `prefer_single_quotes` rule
- always_declare_return_types
- always_put_control_body_on_new_line
# - always_put_required_named_parameters_first
#- always_put_required_named_parameters_first
- always_require_non_null_named_parameters
# - always_specify_types
- always_use_package_imports
- annotate_overrides
# - avoid_annotating_with_dynamic
- avoid_annotating_with_dynamic
- avoid_bool_literals_in_conditional_expressions
# - avoid_catches_without_on_clauses
- avoid_catching_errors
# - avoid_classes_with_only_static_members
#- avoid_classes_with_only_static_members
- avoid_double_and_int_checks
# - avoid_dynamic_calls
- avoid_empty_else
- avoid_equals_and_hash_code_on_mutable_classes
- avoid_escaping_inner_quotes
- avoid_field_initializers_in_const_classes
- avoid_final_parameters
- avoid_function_literals_in_foreach_calls
# - avoid_implementing_value_types
- avoid_implementing_value_types
- avoid_init_to_null
- avoid_js_rounded_ints
- avoid_multiple_declarations_per_line
- avoid_null_checks_in_equality_operators
- avoid_positional_boolean_parameters
- avoid_print
- avoid_private_typedef_functions
# - avoid_redundant_argument_values
#- avoid_redundant_argument_values
- avoid_relative_lib_imports
- avoid_renaming_method_parameters
- avoid_return_types_on_setters
- avoid_returning_null
- avoid_returning_null_for_future
- avoid_returning_null_for_void
- avoid_returning_this
- avoid_setters_without_getters
Expand All @@ -95,18 +97,23 @@ linter:
- camel_case_extensions
- camel_case_types
- cancel_subscriptions
# - cascade_invocations
- cascade_invocations
- cast_nullable_to_non_nullable
- close_sinks
- collection_methods_unrelated_type
- combinators_ordering
- comment_references
- conditional_uri_does_not_exist
- constant_identifier_names
- control_flow_in_finally
- curly_braces_in_flow_control_structures
- dangling_library_doc_comments
- depend_on_referenced_packages
- deprecated_consistency
# - diagnostic_describe_all_properties
- deprecated_member_use_from_same_package
#- diagnostic_describe_all_properties
- directives_ordering
#- discarded_futures
- do_not_use_environment
- empty_catches
- empty_constructor_bodies
Expand All @@ -117,21 +124,29 @@ linter:
- flutter_style_todos
- hash_and_equals
- implementation_imports
- implicit_call_tearoffs
- implicit_reopen
- invalid_case_patterns
- join_return_with_assignment
- leading_newlines_in_multiline_strings
- library_annotations
- library_names
- library_prefixes
- library_private_types_in_public_api
- lines_longer_than_80_chars
- literal_only_boolean_expressions
- matching_super_parameters
- missing_whitespace_between_adjacent_strings
- no_adjacent_strings_in_list
# - no_default_cases
- no_duplicate_case_values
- no_leading_underscores_for_library_prefixes
- no_leading_underscores_for_local_identifiers
- no_literal_bool_comparisons
- no_logic_in_create_state
- no_runtimeType_toString
- no_self_assignments
- no_wildcard_variable_uses
- non_constant_identifier_names
- noop_primitive_operations
- null_check_on_nullable_type_parameter
Expand Down Expand Up @@ -187,28 +202,34 @@ linter:
# - public_member_api_docs
- recursive_getters
- require_trailing_commas
- secure_pubspec_urls
- sized_box_for_whitespace
- sized_box_shrink_expand
- slash_for_doc_comments
- sort_child_properties_last
# - sort_constructors_first
- sort_constructors_first
- sort_pub_dependencies
- sort_unnamed_constructors_first
- test_types_in_equals
- throw_in_finally
- tighten_type_of_initializing_formals
- type_annotate_public_apis
# - type_annotate_public_apis
- type_init_formals
- type_literal_in_constant_pattern
- unawaited_futures
- unnecessary_await_in_return
- unnecessary_brace_in_string_interps
- unnecessary_breaks
- unnecessary_const
- unnecessary_constructor_name
# - unnecessary_final
- unnecessary_getters_setters
- unnecessary_lambdas
- unnecessary_late
- unnecessary_library_directive
- unnecessary_new
- unnecessary_null_aware_assignments
- unnecessary_null_aware_operator_on_extension_on_nullable
- unnecessary_null_checks
- unnecessary_null_in_if_null_operators
- unnecessary_nullable_for_final_variable_declarations
Expand All @@ -219,9 +240,14 @@ linter:
- unnecessary_string_escapes
- unnecessary_string_interpolations
- unnecessary_this
- unnecessary_to_list_in_spreads
- unreachable_from_main
- unrelated_type_equality_checks
- unsafe_html
- use_build_context_synchronously
- use_colored_box
- use_decorated_box
- use_enums
- use_full_hex_values_for_flutter_colors
- use_function_type_syntax_for_parameters
- use_if_null_to_convert_nulls_to_bools
Expand All @@ -233,6 +259,8 @@ linter:
- use_rethrow_when_possible
- use_setters_to_change_properties
- use_string_buffers
- use_string_in_part_of_directives
- use_super_parameters
- use_test_throws_matchers
- use_to_and_as_if_applicable
- valid_regexps
Expand Down
2 changes: 1 addition & 1 deletion example/lib/cupertino_example.dart
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ class ChildWidget extends StatelessWidget {
const ChildWidget({super.key});

@override
Widget build(BuildContext context) => Container(
Widget build(BuildContext context) => ColoredBox(
color: Colors.orange,
child: TextButton(
onPressed: generateError,
Expand Down
4 changes: 2 additions & 2 deletions example/lib/custom_navigator_key_example.dart
Original file line number Diff line number Diff line change
Expand Up @@ -20,10 +20,10 @@ void main() {
}

class MyApp extends StatefulWidget {
final GlobalKey<NavigatorState> navigatorKey;

const MyApp(this.navigatorKey, {super.key});

final GlobalKey<NavigatorState> navigatorKey;

@override
State<MyApp> createState() => _MyAppState();
}
Expand Down
3 changes: 1 addition & 2 deletions example/lib/custom_report_mode_example.dart
Original file line number Diff line number Diff line change
Expand Up @@ -88,11 +88,10 @@ class CustomPageReportMode extends ReportMode {
}

class CustomPage extends StatelessWidget {
const CustomPage(this.reportMode, this.report, {super.key});
final ReportMode reportMode;
final Report report;

const CustomPage(this.reportMode, this.report, {super.key});

@override
Widget build(BuildContext context) => Scaffold(
appBar: AppBar(
Expand Down
13 changes: 6 additions & 7 deletions example/lib/local_notification_example.dart
Original file line number Diff line number Diff line change
Expand Up @@ -59,6 +59,12 @@ class ChildWidget extends StatelessWidget {
}

class NotificationReportMode extends ReportMode {
NotificationReportMode({
this.channelId = 'Catcher 2',
this.channelName = 'Catcher 2',
this.channelDescription = 'Catcher 2 default channel',
this.icon = '@mipmap/ic_launcher',
});
late FlutterLocalNotificationsPlugin _flutterLocalNotificationsPlugin;
late Report _lastReport;

Expand All @@ -67,13 +73,6 @@ class NotificationReportMode extends ReportMode {
final String channelDescription;
final String icon;

NotificationReportMode({
this.channelId = 'Catcher 2',
this.channelName = 'Catcher 2',
this.channelDescription = 'Catcher 2 default channel',
this.icon = '@mipmap/ic_launcher',
});

@override
set reportModeAction(ReportModeAction reportModeAction) {
_initializeNotificationsPlugin();
Expand Down
2 changes: 2 additions & 0 deletions lib/catcher_2.dart
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
/// Library for error catching which provides multiple handlers for dealing with
/// errors when they are not caught by the developer.
library catcher_2;

export 'package:catcher_2/core/catcher_2.dart';
Expand Down
20 changes: 10 additions & 10 deletions lib/core/application_profile_manager.dart
Original file line number Diff line number Diff line change
Expand Up @@ -19,21 +19,21 @@ class ApplicationProfileManager {
return ApplicationProfile.debug;
}

/// Check if current platform is web
/// Check if current platform is Web
static bool isWeb() => kIsWeb;

/// Check if current platform is android
static bool isAndroid() => Platform.isAndroid;
/// Check if current platform is Android
static bool isAndroid() => !kIsWeb && Platform.isAndroid;

/// Check if current platform is ios
static bool isIos() => Platform.isIOS;
/// Check if current platform is iOS
static bool isIos() => !kIsWeb && Platform.isIOS;

/// Check if current platform is linux
static bool isLinux() => Platform.isLinux;
/// Check if current platform is Linux
static bool isLinux() => !kIsWeb && Platform.isLinux;

/// Check if current platform is windows
static bool isWindows() => Platform.isWindows;
/// Check if current platform is Windows
static bool isWindows() => !kIsWeb && Platform.isWindows;

/// Check if current platform is macOS
static bool isMacOS() => Platform.isMacOS;
static bool isMacOS() => !kIsWeb && Platform.isMacOS;
}
Loading

0 comments on commit 72bf3ee

Please sign in to comment.