Skip to content

Commit

Permalink
reactivate mssql tests
Browse files Browse the repository at this point in the history
The `go:debug x509negativeserial=1` fixes the certificate issue with the mssql server image
See: microsoft/mssql-docker#895
  • Loading branch information
Thiht committed Dec 30, 2024
1 parent a33a511 commit 965bc4c
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 4 deletions.
3 changes: 1 addition & 2 deletions tests/sqlx/transactor_integration_test.go
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
//go:debug x509negativeserial=1
package sqlx_test

import (
Expand Down Expand Up @@ -720,8 +721,6 @@ func TestIntegrationTransactorOracle(t *testing.T) {
func TestIntegrationTransactorMSSQL(t *testing.T) {
t.Parallel()

t.Skip("Waiting for this issue to be fixed: https://github.com/microsoft/mssql-docker/issues/895")

ctx := context.Background()

testcontainers.DefaultLoggingHook = func(_ testcontainers.Logging) testcontainers.ContainerLifecycleHooks {
Expand Down
3 changes: 1 addition & 2 deletions tests/stdlib/transactor_integration_test.go
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
//go:debug x509negativeserial=1
package stdlib_test

import (
Expand Down Expand Up @@ -720,8 +721,6 @@ func TestIntegrationTransactorOracle(t *testing.T) {
func TestIntegrationTransactorMSSQL(t *testing.T) {
t.Parallel()

t.Skip("Waiting for this issue to be fixed: https://github.com/microsoft/mssql-docker/issues/895")

ctx := context.Background()

testcontainers.DefaultLoggingHook = func(_ testcontainers.Logging) testcontainers.ContainerLifecycleHooks {
Expand Down

0 comments on commit 965bc4c

Please sign in to comment.