There is a bug in the get_examples_from_df module

[knc6]

The get_examples_from_df requires a pandas dataframe and not a list.

[luketudge]

I am not totally sure, but I think this is not a bug.

The body of the get_examples_from_df function expects a pandas dataframe, yes, and it won't work if you pass a list instead, but is there a good reason why the function should accept and convert lists? The general convention in Python is not to do type checking and conversion unless there is a particular reason. If conversion of other types to dataframes were to be implemented consistently throughout the simpletransformers code then there are a lot more places it would need to be inserted than just here.

If anything does need to change here it is that the function should have a docstring and/or type hints that clarify the expected input types.

But please do clarify if there is a case where your proposed change is important! I may have misunderstood.

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.