fix evaluation during training for t5 #1551
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #1524: When evaluating a T5 model during training a TypeError is thrown.
This was because the eval_model method tried to get the inputs for the evaluation from the wrong dataset. I think
eval_dataset
contains the encoded inputs (and does not have column names) - the fix was just replacing the reference toeval_dataset
witheval_data
which is the dataframe that eval_data gets from the arguments to thetrain_model
method.There might be some superfluous work here as the model feeds the inputs through the model twice instead of just doing additional processing of the outputs of
T5model.evaluate()
- but my solution works as a hotfix.