Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix evaluation during training for t5 #1551

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

lukaszett
Copy link

This fixes #1524: When evaluating a T5 model during training a TypeError is thrown.

This was because the eval_model method tried to get the inputs for the evaluation from the wrong dataset. I think eval_dataset contains the encoded inputs (and does not have column names) - the fix was just replacing the reference to eval_dataset with eval_data which is the dataframe that eval_data gets from the arguments to the train_model method.

There might be some superfluous work here as the model feeds the inputs through the model twice instead of just doing additional processing of the outputs of T5model.evaluate() - but my solution works as a hotfix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TypeError when training T5 with evaluate_during_training=True
1 participant