Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FinalIK Fixes #16

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

VirtualBrightPlayz
Copy link
Contributor

Next steps: adding an offset to the hand/palm positions

@200Tigersbloxed 200Tigersbloxed changed the title Fix avatar head and hand rotation in VR FinalIK Fixes Oct 28, 2024
@200Tigersbloxed
Copy link
Contributor

This is a great WIP PR! The hand and head rotations work excellent! Unfortunately there are other problems.

  1. The first obvious one is the hips are still jank. Turning your head causes the hips to rotate very drastically.
    • This should be fixed with some configuration value, but I'm unsure
  2. Hands are incredibly offset. Even just applying an offset of (0.1f, 0, 0) provides the following output on all avatars

Hypernex-2024-10-1_11-34-40 763

Notice how the hands are on two completely different levels, despite the controllers being side-by-side in real life.

  1. Head is still locked on y. You can replicate this by trying to look all the way up and eventually your head will no longer look so far up.
    • I believe this is an issue with our current animations, so I will look further into that.

@200Tigersbloxed 200Tigersbloxed added the bug Something isn't working label Oct 28, 2024
@200Tigersbloxed 200Tigersbloxed marked this pull request as draft October 28, 2024 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants