Combine Windows CI with Ubuntu and macOS #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DimitrisStaratzis
approved these changes
Aug 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My original plan was to upgrade gradle/gradle-build-action@v3 to gradle/actions/setup-gradle@v4 (#20 (comment)). However, after I had done that, the Windows CI looked so similar to the Ubuntu and macOS CI, that it felt unnecessary to keep separate.
In addition to combining the CI into a single job, I also replaced
ubuntu-latestwithubuntu-22.04, as recently suggested in #14 (comment).The only remaining difference for the separate Windows job was the use of the argument
check-latest: falseforactions/setup-java. There was no explanation in #6 to explain the discrepancy. I can switch it tofalseif desired.