-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add an 'official' caller for batch UDFs #632
base: main
Are you sure you want to change the base?
Conversation
@@ -46,6 +49,8 @@ | |||
from . import visualization as viz | |||
from .mode import Mode | |||
|
|||
logger = logging.getLogger(__name__) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For uniformity reasons, I prefer that we use tiledb.cloud.utilities.get_logger_wrapper
for logging everywhere.
The method also allows for a verbosity level (verbose=True/False
) that should be set from the UDF's arguments (as is the case with the as_batch
method) so the logger
can be declared inside the exec_batch_udf
and the verbose
should be "grabbed" from the kwargs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@JohnMoutafis I agree, but we have a circular import problem because run_dag
is in the utilities module.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@spencerseale @JohnMoutafis are we still stuck here? Do I understand correctly that we don't have a circular import yet, but will when run_dag()
calls this new function?
If we refactored and moved get_logger_wrapper()
to, for example, tiledb.cloud.logging
, that would eliminate the potential circular import, yes? I'm willing to do that work.
Pull in the logging module
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Up for any ideas, including |
This is more approachable from a docs point of view compared to
as_batch
and accepts both in-memory and references to registered UDFs.Because of the interests of users for calling UDFs with custom resource specifications and access credential names, this function acts to satisfy that interest.
For unit tests, didn't want to interfere with
unittest
based tests, so created a new test module for pytest-based.