-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NewContext should use tiledb_ctx_alloc_with_error #223
base: master
Are you sure you want to change the base?
NewContext should use tiledb_ctx_alloc_with_error #223
Conversation
This pull request has been linked to Shortcut Story #18266: Use |
8657c26
to
5eee8cd
Compare
This allows capturing any errors on alloc of the context.
5eee8cd
to
8c27f0b
Compare
@@ -4,6 +4,7 @@ package tiledb | |||
#cgo LDFLAGS: -ltiledb | |||
#cgo linux LDFLAGS: -ldl | |||
#include <tiledb/tiledb.h> | |||
#include <tiledb/tiledb_experimental.h> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since this is experimental, do we need to have a separate "experimental" vs. "non-experimental" file for this, with a flag like this:
TileDB-Go/array_schema_evolution.go
Line 1 in a1ad55b
//go:build experimental |
(and a corresponding "not experimental" file)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well this API is experimental mostly because we don't know why allocs fail. Once we collect some of the errors that will inform us about the reasons and lead to possible API changes in which we might want to remove or change this with_error
API.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is about separating things which use "experimental" TileDB APIs versus the stable ones, and the assumption that I assume we make that only stable APIs should be included when building without -tags=experimental
. I have an example of what I mean by this here: 53e5e08
@snagles we should revist this to start collecting the errors. |
…-with-error-to-capture
CI fails because |
This allows capturing any errors on alloc of the context.