-
Notifications
You must be signed in to change notification settings - Fork 240
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Simple Demo #140
base: main
Are you sure you want to change the base?
Simple Demo #140
Conversation
thanks for the contribution!
|
I think that the main problem is its complexity. I came up with the simple_demo to try to implement only the features related to this library and commenting them at each step. Maybe it is too commented, but the app is so small that it should not be a problem. I have set the dependencies like that on purpose because I found in some posts online a bit of confusion regarding this topic. If you are considering pulling this, I will gladly comment them out and change them (and the naming convention as well). |
I just try to compile the origin demo without success. The readme file just showed some code snipper and there are many dependencies code missing. |
can you open an issue with what error message you got with compiling with the demo app in the repo? |
@lolloz98 is there anything you think is missing in the https://github.com/Tinder/Scarlet#usage? |
the first step for this PR to be reviewed further is to make use of the existing infrastructure set up in the repo, e.g., centralized .gitignore and adding this as an additional module rather than creating a new Gradle project etc. |
I found the provided demo a bit difficult to read.
I thought it could be a good idea to provide an easier demo app: the developers will be able to change the server settings and to really try Scarlet, before diving into the library in their own projects.
I hope it could be of some help.