Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

♻️ Update Changes from New Engine Design #882

Merged
merged 13 commits into from
Nov 21, 2024

Conversation

shaneahmed
Copy link
Member

@shaneahmed shaneahmed commented Nov 21, 2024

  • Add changes from New engine design ⚡ Improve Engine Performance and Implementation #578. This will not only simplify the PR but also keep the main repo up to date.
  • Refactor model_to to model_abc
  • Instead of on_gpu use device as an input in line with PyTorch.
  • infer_batch uses device as an input instead of on_gpu

@shaneahmed shaneahmed added the enhancement New feature or request label Nov 21, 2024
@shaneahmed shaneahmed self-assigned this Nov 21, 2024
Copy link

codecov bot commented Nov 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.90%. Comparing base (32cae0b) to head (f68a29f).
Report is 1 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #882      +/-   ##
===========================================
+ Coverage    99.88%   99.90%   +0.02%     
===========================================
  Files           69       69              
  Lines         8717     8705      -12     
  Branches      1149     1149              
===========================================
- Hits          8707     8697      -10     
+ Misses           4        3       -1     
+ Partials         6        5       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@shaneahmed shaneahmed merged commit ca13e7f into develop Nov 21, 2024
15 checks passed
@shaneahmed shaneahmed deleted the dev-add-changes-from-new-engine-design branch November 21, 2024 22:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant