Fixed "doubleclicking" on Colorpicker #363
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bug: TodePond#315 / TodePond#345 / TodePond#309 Didn't read all the code so hope i got it right. When you close a colorchannel it saves the atoms to reuse the gradiets. When opening it again it checks if the old atoms are there and it copies the gradient. But it only checks if the atom is there so when you close the channel before it has drawn all gradients, the gradient is undefined but isGradient is true. I made it that it also copies the isGradient value from the old atom instead of just setting it true.
✅ Deploy Preview for keen-boyd-1443aa ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
set dx and dy to 0 for the missing cases, when a square gets dropped in a paddle.
If you make the UI too small it get broken and you have to reset.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug: #315 / #345 / #309
Didn't read all the code so hope i got it right.
When you close a colorchannel it saves the atoms to reuse the gradiets. When opening it again it checks if the old atoms are there and it copies the gradient. But it only checks if the atom is there so when you close the channel before it has drawn all gradients, the gradient is undefined but isGradient is true.
I made it that it also copies the isGradient value from the old atom instead of just setting it true.