Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pengen beli BMW tapi kok mahal ya :) #25

Open
wants to merge 23 commits into
base: master
Choose a base branch
from
Open

pengen beli BMW tapi kok mahal ya :) #25

wants to merge 23 commits into from

Conversation

WahidinAji
Copy link
Contributor

ya maaf, namanya juga laper. kadang error kadang signal SIGSEGV: segmentation violation code=0x1 addr=0x18 pc=0x51b1f9]

@WahidinAji WahidinAji added the needs review This PR needs some user reviews label May 17, 2023
@WahidinAji WahidinAji requested a review from a team as a code owner May 17, 2023 02:44
@codecov
Copy link

codecov bot commented May 17, 2023 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 48.85%. Comparing base (6395d75) to head (0c417e0).

Additional details and impacted files 
@@            Coverage Diff             @@
##           master      #25      +/-   ##
==========================================
- Coverage   50.05%   48.85%   -1.20%     
==========================================
  Files          34       37       +3     
  Lines        1962     2235     +273     
==========================================
+ Hits          982     1092     +110     
- Misses        893     1048     +155     
- Partials       87       95       +8

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@aldy505
Copy link
Member

aldy505 commented May 17, 2023

SIGSEV pas kapan?

@WahidinAji
Copy link
Contributor Author

pas running testnya. tpi itu karena ada yg kurang. sekarng dh ga ada SIGNEV lagi

@aldy505 aldy505 assigned WahidinAji and unassigned aldy505 and YogiPristiawan May 17, 2023
aldy505
aldy505 requested changes May 17, 2023
View reviewed changes
Copy link
Member

@aldy505 aldy505 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Jangan pake mock.

business/payment_service/get_details_test.go Outdated Show resolved Hide resolved
business/payment_service/get_details_test.go Outdated Show resolved Hide resolved
business/payment_service/get_details_test.go Outdated Show resolved Hide resolved
@aldy505
Copy link
Member

aldy505 commented May 17, 2023

Sekalian, codecov result nya sampe hijau dulu kalo bikin PR.

@WahidinAji WahidinAji requested a review from aldy505 June 12, 2023 07:48
@WahidinAji
Copy link
Contributor Author

ini nge-cache ato gimana? :/

@WahidinAji
Copy link
Contributor Author

https://github.com/TokoBapak/mock-payment-provider/blob/service-test-mock-repo/business/payment_service/get_details_test.go#LL123C29-L123C29

nge-cache kah? @aldy505

@aldy505
Copy link
Member

aldy505 commented Jun 12, 2023

apanya yang nge cache?

@WahidinAji
Copy link
Contributor Author

apanya yang nge cache?

coba buka link code yg gue kasih sama issue nya ini
image

@aldy505
Copy link
Member

aldy505 commented Jun 19, 2023

apanya yang nge cache?

coba buka link code yg gue kasih sama issue nya ini image

@WahidinAji oh, ini ignore aja kalo dari CodeFactor

aldy505
aldy505 requested changes Jun 19, 2023
View reviewed changes
business/payment_service/get_details_test.go Outdated Show resolved Hide resolved
business/payment_service/get_details_test.go Outdated Show resolved Hide resolved
business/payment_service/get_details_test.go Outdated Show resolved Hide resolved
business/payment_service/get_details_test.go Outdated Show resolved Hide resolved
business/payment_service/mark_as_paid_test.go Outdated Show resolved Hide resolved
business/payment_service/get_details_test.go Outdated Show resolved Hide resolved
business/payment_service/get_details_test.go Outdated Show resolved Hide resolved
business/payment_service/get_details_test.go Outdated Show resolved Hide resolved
business/payment_service/get_details_test.go Outdated Show resolved Hide resolved
business/payment_service/get_details_test.go Outdated Show resolved Hide resolved
@WahidinAji WahidinAji marked this pull request as draft September 3, 2024 12:54
@WahidinAji WahidinAji marked this pull request as ready for review September 3, 2024 14:30
@WahidinAji WahidinAji requested a review from aldy505 September 3, 2024 15:12
@aldy505
Copy link
Member

aldy505 commented Sep 9, 2024

Ini sebenernya PR ngapain sih, gw udah lupa

@WahidinAji
Copy link
Contributor Author

lupa dulu ngapain aja, ingetnya cuma benerin test doang

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YogiPristiawan YogiPristiawan YogiPristiawan approved these changes

@aldy505 aldy505 Awaiting requested review from aldy505

Requested changes must be addressed to merge this pull request.

Assignees

@WahidinAji WahidinAji

Labels
needs review This PR needs some user reviews
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@WahidinAji @aldy505 @YogiPristiawan