forked from facebook/facebook-php-business-sdk
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[75136] update fb sdk #5
Open
andrey-mostovoy
wants to merge
36
commits into
main
Choose a base branch
from
75136-update_fb_sdk
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: [BizSDK][API-Spec] Add DSA Support on AdAccount Add default_dsa_beneficiary and default_dsa_payor two fields in adaccount.json file. Reviewed By: scutexasece Differential Revision: D48134776 fbshipit-source-id: b672146998f4eac5d20ac2e04624c4b41dceafd1
Summary: [BizSDK][PHP] Update LICENSE and Header Reviewed By: mengxuanzhangz Differential Revision: D49199828 fbshipit-source-id: ae5a1851e5c82f6fe5584f678d8953a371c81b6f
Summary: ignore-conflict-markers Reviewed By: stcheng Differential Revision: D49294407 fbshipit-source-id: 647f1e0f6c8172e985cbb46c0845ebb62860fad3
Summary: ignore-conflict-markers Reviewed By: stcheng Differential Revision: D49642986 fbshipit-source-id: d2c0e5d96e977082b95ff449b8e4b35a58ff7ef1
Summary: ignore-conflict-markers Reviewed By: stcheng Differential Revision: D50280588 fbshipit-source-id: 0c0ccac8ccb8c9c5af9a77a162e8f07565433526
Summary: ignore-conflict-markers Reviewed By: stcheng Differential Revision: D50948236 fbshipit-source-id: 631bc21751f943b0f6bf6fed31caab3b7051d380
Summary: ignore-conflict-markers Reviewed By: stcheng Differential Revision: D51766783 fbshipit-source-id: ac1f695a815dfbcde66183513e78ac224dfaa3d5
facebook#592) Summary: Improve instructions to install the package via composer Issue facebook#593 Pull Request resolved: facebook#592 Reviewed By: mengxuanzhangz Differential Revision: D52914476 Pulled By: stcheng fbshipit-source-id: 2afb490e89f2968aa27b1d7d52584d0a8ec8e148
…cebook#594) Summary: :bug: Fix escape string in catalog item appeal status values Pull Request resolved: facebook#594 Reviewed By: mengxuanzhangz Differential Revision: D52982956 Pulled By: stcheng fbshipit-source-id: 586da15dd14f8aaa0e98bb36e582d225fb09f578
Summary: Add support of type KeyValue to Ruby, PHP, and Python. Reviewed By: mengxuanzhangz Differential Revision: D53016094 fbshipit-source-id: 50409b3f7f5f8df38853e266edf46e781c269a47
Summary: ignore-conflict-markers Reviewed By: stcheng Differential Revision: D53020059 fbshipit-source-id: fb1d683e4c9292341830d9a2100a040cdff2be59
Summary: Pull Request resolved: facebook#335 Reviewed By: mengxuanzhangz Differential Revision: D53145922 Pulled By: stcheng fbshipit-source-id: d626f56e7df9df9755895af98cf6516fed50bbab
Summary: ignore-conflict-markers Reviewed By: stcheng Differential Revision: D54566141 fbshipit-source-id: be845cf940ce2c207e8671858d259aceb31c1a83
Summary: CAPI CTWA has been launched to 100% since November 2023, but is still not supported in our Meta Business SDK. This diff adds support for WhatsApp events on the Business SDK. It includes changes to the Event class to add a new field for the messaging channel, as well as changes to the User Data class to include new constants for the CTWA_CLID and PAGE_ID parameters. Reviewed By: stcheng Differential Revision: D54615825 fbshipit-source-id: 67edbe7b4101f3ea571d3d583e585d863ab0ca65
Summary: [BizSDK] Update Supported Destination Types Reviewed By: mengxuanzhangz Differential Revision: D54613743 fbshipit-source-id: 45a3e4bb007aa64944a823d6d19310d8f011b5fb
Summary: [BizSDK] Override Enum EnumAffectedChannels for All Languages Reviewed By: mengxuanzhangz Differential Revision: D54956307 fbshipit-source-id: 54bdd9067039aa8496966f8d563ad4e4127631ee
Summary: ignore-conflict-markers Reviewed By: stcheng Differential Revision: D54971065 fbshipit-source-id: e912137558596dcef4c99d560053d49696740763
Summary: Fixing GuzzleHttp compatibility. Function GuzzleHttp\Promise\unwrap() was removed in guzzlehttp/promises:2.0. https://github.com/guzzle/promises/blob/1.5/src/functions.php#L157 https://github.com/guzzle/promises/blob/2.0.1/CHANGELOG.md#removed Pull Request resolved: facebook#601 Reviewed By: mengxuanzhangz Differential Revision: D55878434 Pulled By: stcheng fbshipit-source-id: 886c4c77d157fd812bcaf18495b59ae66c160dea
Summary: ignore-conflict-markers Reviewed By: stcheng Differential Revision: D56033507 fbshipit-source-id: 0d905f15789f9c0d18d4c8ad291539c44e00c62e
Summary: ignore-conflict-markers Reviewed By: liliarizona Differential Revision: D58591423 fbshipit-source-id: 9695adc477600920ac121d0903eb72348a487035
Summary: Update business SDK to include original event data and attribution data for CAPI payload Differential Revision: D59702763 fbshipit-source-id: 3af042a81d333ed3858f297b1a0bab5adce48ddc
Summary: This example contains the calls necessary to create an ad for the php sdk. The example was added in the codegen php template, then it will be generated in the php sdk Reviewed By: liliarizona Differential Revision: D60455629 fbshipit-source-id: 1a4ac678d4967a8e66de3db84ed2fd48582e6e4f
Summary: Fixes namespace so PHPStorm doesn't throw warnings about wrong expected type <img width="674" alt="Screenshot 2024-07-24 at 3 38 36 PM" src="https://github.com/user-attachments/assets/d9141cc1-04d1-426f-a9f9-a393747565be"> <img width="1186" alt="Screenshot 2024-07-24 at 3 40 13 PM" src="https://github.com/user-attachments/assets/45f0f2ac-8e59-4ffd-8841-84a88c8f401e"> Pull Request resolved: facebook#606 Reviewed By: liliarizona Differential Revision: D61413277 Pulled By: stcheng fbshipit-source-id: 14d15ceaca2bd6f7a6e29046424723e5ceb4e90b
Summary: In Graph API v20, two words are introduced P2MInvoicePayments and WithAsset3D - causing the logic of parsing pascal name to fail and generate 'M' and 'D' as individual words. This caused the endpoint name parsing fail at last. Reviewed By: yoongyj, liliarizona Differential Revision: D61582281 fbshipit-source-id: 4b1cf3f966f433cf1c2a7fa4641ca8048857a0f5
Summary: Bump the version to release a new version with the bug fix. Reviewed By: yoongyj, liliarizona Differential Revision: D61582701 fbshipit-source-id: 1e44ecadc8b78f62ae9752c61196c904850839a3
Summary: ## Issue [https://github.com/facebook/facebook-php-business-sdk/issues/610](https://github.com/facebook/facebook-php-business-sdk/issues/610#issue-2472108763) Fix typo errors in [README.md](README.md) and [CHANGELOG.md](CHANGELOG.md) ## Description #### README.md 1. **Missing Dollar Sign for Variable** ✅ In the [**Create Objects**](https://github.com/facebook/facebook-php-business-sdk/blob/main/README.md#create-objects) section, the `AdSetFields::CAMPAIGN_ID` is missing a `$` before `campaign_id` 2. **Code Block Syntax Highlighting** ✅ Add `shell` tag for [second code block line 335](https://github.com/facebook/facebook-php-business-sdk/blob/main/README.md#debug) #### CHANGELOG.md 1. **Missing Parenthesis for Link Attachment** ✅ In the [**Unreleased v11.0.0**](https://github.com/facebook/facebook-php-business-sdk/blob/main/CHANGELOG.md#v1100), the link attached is missing a pair of parenthesis Pull Request resolved: facebook#611 Reviewed By: yoongyj Differential Revision: D61666440 Pulled By: stcheng fbshipit-source-id: c7e78eaa9611782d96a05850c51c73807d8de0af
Summary: Update EndpointDecodeDict.txt to support new names. Make WhatsApp two words to align with the current situation. Reviewed By: liliarizona Differential Revision: D62056156 fbshipit-source-id: 6337eb9f819cc781c9b9164e0b12753da991ef99
Summary: [BizSDK] Update AdCreativeFeatureDetails Fields Add the customizations field in AdCreativeFeatureDetails node. Also remove some unsupported fields from the AdCreativeFeatureCustomizations node. Reviewed By: liliarizona Differential Revision: D62890910 fbshipit-source-id: 1fdad3ce9d8c17811e67dd1d79d5026ce6b27c89
Summary: as titled Reviewed By: yoongyj, stcheng Differential Revision: D62960011 fbshipit-source-id: cdccbc786e857b514ebbe030cf91628f4ed1ee1f
Summary: added FBC Combiner integration for Business SDK: php Reviewed By: stcheng Differential Revision: D62271151 fbshipit-source-id: ceadcfa1f97d31df89f3944b616b41b4c24a7738
Summary: Update ParamBuilder to 0.1.0-dev for PHP Differential Revision: D64062213 fbshipit-source-id: 5287d98f6bb70ea36d503e6fbc71036ba4c912ae
Summary: ignore-conflict-markers Reviewed By: yoongyj Differential Revision: D64084318 fbshipit-source-id: cf9f895a7977fbfc494352c3bcae5de6d4b6763d
Summary: As titled Differential Revision: D64509782 fbshipit-source-id: 4ee282104b263c227a7a724a9330a24dae39ea2c
Summary: as titled Reviewed By: stcheng, satwikareddy3 Differential Revision: D64510329 fbshipit-source-id: e006b90dd6328f41849ad63252ce592e684b4558
…into 75136-update_fb_sdk
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://tasks.verumnets.ru/issues/75136