kotlin/logging #89
Open
kotlin/logging #89
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxbach
suggested changes
Oct 17, 2019
| private const val MAX_LOG_LENGTH = 4000 | ||
| } | ||
|
|
||
| private fun normalize(message: String): String = message |
| val messageToLog = normalize(message + if (throwable != null) '\n' + Log.getStackTraceString(throwable) else "") | ||
| val length = messageToLog.length | ||
| var i = 0 | ||
| while (i < length) { |
There was a problem hiding this comment.
Перепиши без циклов. В Kotlin стиле
|
|
||
| private val DATE_TIME_FORMATTER = ThreadLocalValue( | ||
| fabric = object : ThreadLocalValue.Fabric<SimpleDateFormat> { | ||
|
|
There was a problem hiding this comment.
не помагает, если только так:
private val DATE_TIME_FORMATTER = ThreadLocalValue(object : ThreadLocalValue.Fabric<SimpleDateFormat> {
override fun create(): SimpleDateFormat = SimpleDateFormat("HH:mm:ss.SSS", Locale.getDefault())
})
| null | ||
| } | ||
|
|
||
| private fun createLogMessage(formattedMessage: String?): String = DATE_TIME_FORMATTER.get()!!.format(System.currentTimeMillis()) |
| * Group of log messages with specific tag prefix (name of group). | ||
| * It could be used in specific [LogProcessor] to filter messages by group. | ||
| */ | ||
| @SuppressWarnings("checkstyle:methodname", "PMD.ShortMethodName") |
There was a problem hiding this comment.
checkstyle и PMD больше не используем
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
logging: Java => Kotlin