Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix some crashes #21

Merged
merged 6 commits into from
Dec 27, 2023
Merged

Fix some crashes #21

merged 6 commits into from
Dec 27, 2023

Conversation

ahcorde
Copy link
Collaborator

@ahcorde ahcorde commented Dec 22, 2023

If there are some exceptions when running the code then the rqt plugins stop working. This PR should fix most of them. Mainly subscribe to a wrong topic name

FIY @caguero

Signed-off-by: Alejandro Hernández Cordero <[email protected]>
Signed-off-by: Alejandro Hernandez Cordero <[email protected]>
Signed-off-by: Alejandro Hernández Cordero <[email protected]>
@ahcorde ahcorde self-assigned this Dec 22, 2023
Signed-off-by: Alejandro Hernández Cordero <[email protected]>
@ahcorde ahcorde mentioned this pull request Dec 22, 2023
@ahcorde ahcorde changed the base branch from ahcorde/cleanups to main December 26, 2023 17:14
else:
print('The brake pedal value is not between 0 and 1')
print('The throttle pedal value is not valid')
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

brake?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Signed-off-by: Alejandro Hernández Cordero <[email protected]>
@ahcorde ahcorde requested a review from caguero December 26, 2023 17:50
@ahcorde ahcorde merged commit 3b10255 into main Dec 27, 2023
2 checks passed
@ahcorde ahcorde deleted the ahcorde/fix_crashes branch December 27, 2023 07:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants