Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#46 Fixes the bug that keeps running the app alive when there is a lag, but no message in the topic partition #47

Merged
merged 5 commits into from
Sep 24, 2024
Merged

#46 Fixes the bug that keeps running the app alive when there is a lag, but no message in the topic partition #47

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
648f0d2
#29 adds missing configurations to the read me
Aug 29, 2024
f306510
Merge branch 'Trendyol:main' into main
ahmetfurkankavraz Aug 29, 2024
4dc4f3a
#46 fixes the bug, that keeps running the app alive when there is a l…
Sep 24, 2024
c3cd234
Merge remote-tracking branch 'origin/main'
Sep 24, 2024
1a476bf
Merge branch 'Trendyol:main' into main
ahmetfurkankavraz Sep 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/publish.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ jobs:
name: Build & push Docker image
with:
image: kafka-retry-job
tags: 1.12.4, latest
tags: 1.12.5, latest
registry: ghcr.io
username: ${{ secrets.GHCR_USERNAME }}
password: ${{ secrets.GHCR_TOKEN }}
Expand Down
2 changes: 1 addition & 1 deletion .gitlab-ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@

variables:
VERSION: "1.12.4"
VERSION: "1.12.5"
DOCKER_IMAGE_VERSION: $GITLAB_REGISTRY_HOST/$CI_PROJECT_PATH:$VERSION
DOCKER_IMAGE_LATEST: $GITLAB_REGISTRY_HOST/$CI_PROJECT_PATH

Expand Down
8 changes: 8 additions & 0 deletions CHANGELOG.MD
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,13 @@
# Changelog

## [1.12.5](https://github.com/github-changelog-generator/github-changelog-generator/tree/1.16.4) (2024-03)

- [\#46](https://github.com/Trendyol/kafka-retry-job/issues/46) Fixes the bug that keeps running the app alive when there is a lag, but no message in the topic partition

**Merged pull requests:**

- Pull Request for the issues #46 [\#46](https://github.com/Trendyol/kafka-retry-job/pull/46) ([ahmetfurkankavraz](https://github.com/ahmetfurkankavraz))

## [1.12.4](https://github.com/github-changelog-generator/github-changelog-generator/tree/1.16.4) (2024-03)

- [\#29](https://github.com/Trendyol/kafka-retry-job/issues/29) Add async programming to consume message in parallel
Expand Down
2 changes: 1 addition & 1 deletion src/Services/Implementations/KafkaRetryJobService.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,7 +104,7 @@ Action<IConsumer<string,string>, ConsumeResult<string,string>> consumerCommitStr

if (result is null)
{
continue;
break;
}

currentLag -= 1;
Expand Down
Loading