Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

we don't want to call setState after unmount. #90

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

unworthyEnzyme
Copy link

@unworthyEnzyme unworthyEnzyme commented Sep 22, 2022

Description

We should cleanup all the async tasks after react unmounts the component otherwise this can potentially cause a memory leak.

Additional context

I am not sure if this is a right solution in the case of react code. We could use a cancel token with useRef but this solution seemed more framework agnostic.


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.
    diff --git a/.github/workflows/PULL_REQUEST_TEMPLATE.md b/.github/workflows/PULL_REQUEST_TEMPLATE.md

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant