Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chore/bump packages #1917

Merged
merged 13 commits into from
Oct 16, 2023
Merged

Chore/bump packages #1917

merged 13 commits into from
Oct 16, 2023

Conversation

vinkabuki
Copy link
Contributor

Pull Request Checklist

  • I have linked this PR to related GitHub issue.
  • I have updated the CHANGELOG.md file with relevant changes (the file is located at the root of monorepo).

@vinkabuki
Copy link
Contributor Author

We've run into that annoying lerna thing not updating package-locks

@vinkabuki vinkabuki marked this pull request as ready for review October 5, 2023 10:52
leblowl
leblowl approved these changes Oct 12, 2023
View reviewed changes
Copy link
Collaborator

@leblowl leblowl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, squashing commits will help keep develop cleaner and easier to read

@vinkabuki vinkabuki merged commit 8c63ea6 into develop Oct 16, 2023
22 of 25 checks passed
@siepra siepra deleted the chore/bump-packages branch December 8, 2023 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leblowl leblowl leblowl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vinkabuki @leblowl